DevTools: [Console] speedup array autocompletion

DevTools: [Console] speedup array autocompletion

The patch avoids serializing array indexes in getCompletions
function.

BUG=585877
R=pfeldman, kozyatinskiy

Committed: https://crrev.com/b10b134f884a744e9601cca82cbe6e83e85467d1
Cr-Commit-Position: refs/heads/master@{#374801}

[lushnikov, 2016-02-10 20:26:43]

ptal

[kozy, 2016-02-10 20:32:52]

lgtm

[kozy, 2016-02-10 20:35:04]

Hm..
When I type var a = [1,2,3] in array and then use auto complete I can see [0,
[1, [2 in auto complete list.
For var a = new Array(1024) there are no indexes in auto complete. It looks like
we've somewhere code that implements this logic. Can we reuse it?

[lushnikov, 2016-02-10 20:40:58]

As per offline discussion, omitting array indexes turned out to be a good thing!
Landing.

[lushnikov, 2016-02-10 20:41:03]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-02-10 20:43:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685683006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685683006/1

[commit-bot: I haz the power, 2016-02-10 22:00:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 22:00:17]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2016-02-10 22:36:33]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-02-10 22:36:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/1685683006/#ps20001
(title: "fix test")

[commit-bot: I haz the power, 2016-02-10 22:39:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685683006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685683006/20001

[commit-bot: I haz the power, 2016-02-11 00:24:26]

Committed patchset #2 (id:20001)

[PhistucK, 2016-02-11 06:44:04]

phistuck@gmail.com changed reviewers:
+ phistuck@gmail.com

[PhistucK, 2016-02-11 06:44:05]

Would caching some of the lookups speed it up even more?
http://jsperf.com/cachedvsnoncached/3
                var resultSet = {};
                for (var o = object; o; o = o.__proto__) {
                    try {
                        if (type === "array" && o === object &&
ArrayBuffer.isView(o) && o.length > 9999)
                            continue;
                        var names = Object.getOwnPropertyNames(o);
                        var isArray = Array.isArray(o);
                        var length = names.length; // Added.
                        var pattern = /^[0-9]/; // Added.
                        for (var i = 0; i < length; ++i) { // Changed.
                          var currentName = names[i]; // Added. let would be
better, semantically, though.
                          // Skip array elements indexes.
                          if (isArray && pattern.test(currentName)) // Changed.
                            continue;
                          resultSet[currentName] = true; // Changed.
                        }
                    } catch (e) {
                    }
                }
                return resultSet;

[commit-bot: I haz the power, 2016-02-16 22:33:07]

Description was changed from

==========
DevTools: [Console] speedup array autocompletion

The patch avoids serializing array indexes in getCompletions
function.

BUG=585877
R=pfeldman, kozyatinskiy
==========

to

==========
DevTools: [Console] speedup array autocompletion

The patch avoids serializing array indexes in getCompletions
function.

BUG=585877
R=pfeldman, kozyatinskiy

Committed: https://crrev.com/b10b134f884a744e9601cca82cbe6e83e85467d1
Cr-Commit-Position: refs/heads/master@{#374801}
==========

[commit-bot: I haz the power, 2016-02-16 22:33:07]

Patchset 2 (id:??) landed as
https://crrev.com/b10b134f884a744e9601cca82cbe6e83e85467d1
Cr-Commit-Position: refs/heads/master@{#374801}

[lushnikov, 2016-02-16 23:23:30]

@phistuck: the goal of the patch is to send less amount of data from inspected
page to inspector.