Move media::AudioCodec to its own source file

Move media::AudioCodec to its own source file

Also export media::AudioCodecToCodecID to keep symmetry with video.

BUG=571417
R=dalecurtis@chromium.org, jrummell@chromium.org

Committed: https://crrev.com/c2354045a4b129efd582a237802f83a6e4e85883
Cr-Commit-Position: refs/heads/master@{#378192}

[Julien Isorce Samsung, 2016-02-11 13:33:27]

Description was changed from

==========
WIP: add FFmpegAudioDecoder::IsCodecSupported and add audio_codecs.h/.cc

To reflect with what is done for video.

BUG=571417
==========

to

==========
Add FFmpegAudioDecoder::IsCodecSupported and move AudioCodec to its own source
file

To reflect what is done for video.

BUG=571417
==========

[Julien Isorce Samsung, 2016-02-11 13:33:27]

j.isorce@samsung.com changed reviewers:
+ jrummell@chromium.org

[jrummell, 2016-02-11 22:23:19]

LG. Just one question.

https://codereview.chromium.org/1685683004/diff/20001/media/filters/ffmpeg_au...
File media/filters/ffmpeg_audio_decoder.h (right):

https://codereview.chromium.org/1685683004/diff/20001/media/filters/ffmpeg_au...
media/filters/ffmpeg_audio_decoder.h:34: static bool IsCodecSupported(AudioCodec
codec, SampleFormat sample_format);
I know that this matches what is in FFmpegVideoDecoder, but there are no callers
for it. Is this necessary? Do you have an upcoming need for it?

[DaleCurtis, 2016-02-11 22:26:41]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-02-11 22:26:42]

https://codereview.chromium.org/1685683004/diff/20001/media/filters/ffmpeg_au...
File media/filters/ffmpeg_audio_decoder.h (right):

https://codereview.chromium.org/1685683004/diff/20001/media/filters/ffmpeg_au...
media/filters/ffmpeg_audio_decoder.h:34: static bool IsCodecSupported(AudioCodec
codec, SampleFormat sample_format);
On 2016/02/11 22:23:19, jrummell wrote:
> I know that this matches what is in FFmpegVideoDecoder, but there are no
callers
> for it. Is this necessary? Do you have an upcoming need for it?

Yeah, I think callers should just invoke the ffmpeg method directly instead of
exposing this.

[Julien Isorce Samsung, 2016-02-12 14:05:02]

On 2016/02/11 22:26:42, DaleCurtis wrote:
>
https://codereview.chromium.org/1685683004/diff/20001/media/filters/ffmpeg_au...
> media/filters/ffmpeg_audio_decoder.h:34: static bool
IsCodecSupported(AudioCodec
> codec, SampleFormat sample_format);
> On 2016/02/11 22:23:19, jrummell wrote:
> > LG. Just one question.
> > I know that this matches what is in FFmpegVideoDecoder, but there are no
> callers
> > for it. Is this necessary? Do you have an upcoming need for it?
> 
> Yeah, I think callers should just invoke the ffmpeg method directly instead of
> exposing this.

Thx for your comments.
I have no upcoming need except for the experimental CL mentioned in the same bug
571417. Either I can find a usage like in the "Patch Set 3" I just uploaded
(sorry, the deltas "2" in media.gyp in due to rebase but others are part of
Patch Set 3) or I can remove FFmpegVideoDecoder::IsCodecSupported and replace
its usage in content/renderer/pepper/video_decoder_shim.cc by a direct call to
"avcodec_find_decoder" (in the condition that it is possible to include ffmpeg
headers from there).

[Julien Isorce Samsung, 2016-02-26 13:12:01]

Description was changed from

==========
Add FFmpegAudioDecoder::IsCodecSupported and move AudioCodec to its own source
file

To reflect what is done for video.

BUG=571417
==========

to

==========
Move media::AudioCodec to its own source file

Also export media::AudioCodecToCodecID to keep symmetry with video.

BUG=571417

R=dalecurtis@chromium.org, jrummell@chromium.org
==========

[Julien Isorce Samsung, 2016-02-26 13:15:15]

I removed the "FFmpegAudioDecoder::IsCodecSupported" addition from the CL since
it is not used.

[DaleCurtis, 2016-02-26 18:21:44]

lgtm

[jrummell, 2016-02-26 18:51:21]

lgtm

[Julien Isorce Samsung, 2016-02-26 19:38:03]

The CQ bit was checked by j.isorce@samsung.com

[commit-bot: I haz the power, 2016-02-26 19:40:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685683004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685683004/60001

[commit-bot: I haz the power, 2016-02-26 20:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:18:00]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Julien Isorce Samsung, 2016-02-29 09:45:02]

On 2016/02/26 20:18:00, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

I forgot to update gn build which what I did in "Patch Set 5" that I just
uploaded.

[Julien Isorce Samsung, 2016-02-29 09:45:19]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-02-29 09:45:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1685683004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-02-29 09:45:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685683004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685683004/80001

[commit-bot: I haz the power, 2016-02-29 10:52:26]

Description was changed from

==========
Move media::AudioCodec to its own source file

Also export media::AudioCodecToCodecID to keep symmetry with video.

BUG=571417

R=dalecurtis@chromium.org, jrummell@chromium.org
==========

to

==========
Move media::AudioCodec to its own source file

Also export media::AudioCodecToCodecID to keep symmetry with video.

BUG=571417

R=dalecurtis@chromium.org, jrummell@chromium.org
==========

[commit-bot: I haz the power, 2016-02-29 10:52:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-29 10:53:50]

Description was changed from

==========
Move media::AudioCodec to its own source file

Also export media::AudioCodecToCodecID to keep symmetry with video.

BUG=571417

R=dalecurtis@chromium.org, jrummell@chromium.org
==========

to

==========
Move media::AudioCodec to its own source file

Also export media::AudioCodecToCodecID to keep symmetry with video.

BUG=571417

R=dalecurtis@chromium.org, jrummell@chromium.org

Committed: https://crrev.com/c2354045a4b129efd582a237802f83a6e4e85883
Cr-Commit-Position: refs/heads/master@{#378192}
==========

[commit-bot: I haz the power, 2016-02-29 10:53:51]

Patchset 5 (id:??) landed as
https://crrev.com/c2354045a4b129efd582a237802f83a6e4e85883
Cr-Commit-Position: refs/heads/master@{#378192}