tracing/tracing/value/value.html - Issue 1685683003: Implement Timeline Based Measurement v2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/value/value.html

Issue 1685683003: Implement Timeline Based Measurement v2 (Closed) Base URL: git@github.com:catapult-project/catapult.git@new_style_results

Patch Set: fix vinn tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/value/value.html

diff --git a/tracing/tracing/value/value.html b/tracing/tracing/value/value.html

index e592ba5e9e7be8524aaa7be53b718d3350668b41..56373a7fab6566ab7281425dcb7c888889111ccb 100644

--- a/tracing/tracing/value/value.html

+++ b/tracing/tracing/value/value.html

@@ -94,8 +94,6 @@ tr.exportTo('tr.v', function() {

}

NumericValue.fromDict = function(d) {

- if (d.units !== undefined)

- throw new Error('Expected units to be undefined');

if (d.numeric === undefined)

throw new Error('Expected numeric to be provided');

var numeric = tr.v.Numeric.fromDict(d.numeric);

« no previous file with comments | « tracing/tracing/metrics/value_list.html ('k') | tracing/tracing_project.py » ('j') | no next file with comments »