telemetry/telemetry/value/skip.py - Issue 1685683003: Implement Timeline Based Measurement v2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/value/skip.py

Issue 1685683003: Implement Timeline Based Measurement v2 (Closed) Base URL: git@github.com:catapult-project/catapult.git@new_style_results

Patch Set: fix vinn tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/value/skip.py

diff --git a/telemetry/telemetry/value/skip.py b/telemetry/telemetry/value/skip.py

index 7e1bdcf28033336ea4360cda158ea991912af6fc..1dd010849d118a565d3a98bcc2b550bc25e028ec 100644

--- a/telemetry/telemetry/value/skip.py

+++ b/telemetry/telemetry/value/skip.py

@@ -14,7 +14,8 @@ class SkipValue(value_module.Value):

page: The skipped page object.

reason: The string reason the page was skipped.

"""

- super(SkipValue, self).__init__(page, 'skip', '', True, description, None)

+ super(SkipValue, self).__init__(page, 'skip', '', True, description, None,

+ None)

self._reason = reason

def __repr__(self):

@@ -60,6 +61,8 @@ class SkipValue(value_module.Value):

kwargs['reason'] = value_dict['reason']

if 'tir_label' in kwargs:

del kwargs['tir_label']

+ if 'grouping_keys' in kwargs:

+ del kwargs['grouping_keys']

return SkipValue(**kwargs)