telemetry/telemetry/value/merge_values.py - Issue 1685683003: Implement Timeline Based Measurement v2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/value/merge_values.py

Issue 1685683003: Implement Timeline Based Measurement v2 (Closed) Base URL: git@github.com:catapult-project/catapult.git@new_style_results

Patch Set: fix vinn tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/value/merge_values.py

diff --git a/telemetry/telemetry/value/merge_values.py b/telemetry/telemetry/value/merge_values.py

index ef6d0ab7a97a712c4a1857b31d37c4c88010c257..0eb3302bbc72789cbf4b70091f7dd80a6f6d5aa0 100644

--- a/telemetry/telemetry/value/merge_values.py

+++ b/telemetry/telemetry/value/merge_values.py

@@ -21,7 +21,11 @@ def DefaultKeyFunc(value):

Returns:

A comparable object used to group values.

"""

- return value.name, value.tir_label

+ # Grouping keys is a dict but key funcs need to be hashable, so we transform

+ # it to a sorted tuple of tuples here.

+ grouping_keys_sorted = tuple(sorted(value.grouping_keys.iteritems()))

+ return ((('value_name', value.name), ('ue_stable_id', value.tir_label)) +

+ grouping_keys_sorted)

def MergeLikeValuesFromSamePage(all_values, key_func=DefaultKeyFunc):