abort completion request - fixes #24271

abort completion request - fixes #24271

This CL aborts completion requests (returns empty list of completions)
if either a newer completion request is received
or the source changes after the completion request was received.

In addition, I wrapped calls to AnalysisFutureHelper computeAsync
in exception handlers so that it will be easier to track async exceptions
back to the code that requested the computations.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/3fc06a4aa7c506a260aee1d91d5b14c5726662d0

[danrubel, 2016-02-09 18:26:24]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-02-09 18:54:47]

LGTM

https://codereview.chromium.org/1685653002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
(right):

https://codereview.chromium.org/1685653002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:87:
class AbortCompletion {}
Sort file

[danrubel, 2016-02-10 17:44:39]

https://codereview.chromium.org/1685653002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
(right):

https://codereview.chromium.org/1685653002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:87:
class AbortCompletion {}
On 2016/02/09 18:54:47, Brian Wilkerson wrote:
> Sort file

Done.

[danrubel, 2016-02-10 17:45:39]

Description was changed from

==========
abort completion request - fixes #24271

This CL aborts completion requests (returns empty list of completions)
if either a newer completion request is received
or the source changes after the completion request was received.

In addition, I wrapped calls to AnalysisFutureHelper computeAsync
in exception handlers so that it will be easier to track async exceptions
back to the code that requested the computations.
==========

to

==========
abort completion request - fixes #24271

This CL aborts completion requests (returns empty list of completions)
if either a newer completion request is received
or the source changes after the completion request was received.

In addition, I wrapped calls to AnalysisFutureHelper computeAsync
in exception handlers so that it will be easier to track async exceptions
back to the code that requested the computations.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3fc06a4aa7c506a260aee1d91d5b14c5726662d0
==========

[danrubel, 2016-02-10 17:45:40]

Committed patchset #3 (id:40001) manually as
3fc06a4aa7c506a260aee1d91d5b14c5726662d0 (presubmit successful).