Issue 1685643002: dart2js cps: Set the return type on adapters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1685643002: dart2js cps: Set the return type on adapters. (Closed)

Created:
4 years, 10 months ago by asgerf

Modified:
4 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang), Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Set the return type on adapters. The return type of an adapter function was not set, preventing further inlining of methods whose receiver depends on the return value. CLOSES #25725. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/aeb36c9314dafc4e95b4aa0393cf935e2ea47254

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/inline.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

4 years, 10 months ago (2016-02-10 10:47:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
aeb36c9314dafc4e95b4aa0393cf935e2ea47254 (presubmit successful).