Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1685593002: [regexp] experimental implementation for \p property class. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 9 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] experimental implementation for \p property class. Currently we only support general categories for property classes. R=erik.corry@gmail.com, erikcorry@chromium.org, littledan@chromium.org BUG=v8:4743 LOG=N Committed: https://crrev.com/e0d0c96a5384f7c8738072abbf0a1f68fbb4604f Cr-Commit-Position: refs/heads/master@{#33872}

Patch Set 1 #

Patch Set 2 : add ignore case test and simplify parsing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -2 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/regexp-parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 2 chunks +66 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/unicode-regexp-property-class.js View 1 1 chunk +64 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Yang
4 years, 10 months ago (2016-02-09 14:10:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685593002/20001
4 years, 10 months ago (2016-02-09 16:23:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 16:59:02 UTC) #7
Dan Ehrenberg
lgtm
4 years, 10 months ago (2016-02-10 16:05:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685593002/20001
4 years, 10 months ago (2016-02-10 16:10:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 16:24:00 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e0d0c96a5384f7c8738072abbf0a1f68fbb4604f Cr-Commit-Position: refs/heads/master@{#33872}
4 years, 10 months ago (2016-02-10 16:24:13 UTC) #14
PhistucK
Is there any draft specification or draft proposal for that?
4 years, 9 months ago (2016-03-03 17:27:51 UTC) #16
Yang
4 years, 9 months ago (2016-03-03 19:10:02 UTC) #17
Message was sent while issue was closed.
On 2016/03/03 17:27:51, PhistucK wrote:
> Is there any draft specification or draft proposal for that?

Not yet. That's why it's experimental and behind a flag.

Powered by Google App Engine
This is Rietveld 408576698