Issue 16855009: MIPS: Delegating yield does not re-box result objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16855009: MIPS: Delegating yield does not re-box result objects. (Closed)

Created:
7 years, 6 months ago by kilvadyb

Modified:
7 years, 6 months ago

Reviewers:
wingo, Paul Lind, palfia, danno, kisg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Delegating yield does not re-box result objects. Port r15113 (9d28761) Delegating yield (yield*) should just pass on the iterator results it receives instead of re-boxing them. TEST=mjsunit/harmony/generators-iteration BUG=

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -12 lines)			Patch
	M	src/mips/full-codegen-mips.cc	View		3 chunks	+9 lines, -12 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM, but please fix the nit. https://codereview.chromium.org/16855009/diff/1/src/mips/full-codegen-mips.cc File src/mips/full-codegen-mips.cc (right): https://codereview.chromium.org/16855009/diff/1/src/mips/full-codegen-mips.cc#newcode2124 src/mips/full-codegen-mips.cc:2124: CallIC(value_ic); // result.value ...

7 years, 6 months ago (2013-06-13 17:32:46 UTC) #2

palfia

I cannot upload a new patchset to this issue (I don't own this issue), but ...

7 years, 6 months ago (2013-06-13 17:45:29 UTC) #3

Committed as r15131.

Expand Messages | Collapse Messages