Issue 16855008: An unnecessary check for the range of a smi was being performed in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16855008: An unnecessary check for the range of a smi was being performed in (Closed)

Created:
7 years, 6 months ago by mvstanton

Modified:
7 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

An unnecessary check for the range of a smi was being performed in GenerateRecordCallTarget. The value is either a tagged value or a smi, and if it's a smi, it's an ElementsKind. BUG=

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -15 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 chunk	+0 lines, -5 lines	1 comment	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Danno, Here is a snippet of code that is unnecessary. As an earlier bugfix ...

7 years, 6 months ago (2013-06-13 12:43:03 UTC) #1

danno

7 years, 6 months ago (2013-06-13 15:19:44 UTC) #2

https://codereview.chromium.org/16855008/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (left):

https://codereview.chromium.org/16855008/diff/1/src/arm/code-stubs-arm.cc#old...
src/arm/code-stubs-arm.cc:4696: __ cmp(r3, Operand(terminal_kind_sentinel));
How about you turn this into:

  if (FLAG_debug_code) {
    __ cmp(r3, Operand(terminal_kind_sentinel));
    Check(le, "Array function sentinel is not an Elementskind");
  }

on this and other platforms?

Expand Messages | Collapse Messages