tools/perf/page_sets/tough_video_cases/video.html - Issue 16854013: Telemetry media_measurement plus play action and tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/page_sets/tough_video_cases/video.html

Issue 16854013: Telemetry media_measurement plus play action and tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Split measurement JS from action JS. Wrap JS access in Py class. Add more unit tests. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« tools/perf/page_sets/tough_video_cases/utils.js ('K') | « tools/perf/page_sets/tough_video_cases/utils.js ('k') | tools/perf/perf_tools/media_measurement.py » ('j') | tools/perf/perf_tools/media_metrics.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="utils.js" type="text/javascript"></script>

	5 <video id="video_1" controls></video>

	6 <video id="video_2" src="bear.webm" controls></video>

	7 <video src="bear.webm" autoplay controls></video>

	8 <script type="text/javascript">

	9 var mediaFile = QueryString.mediaFile;
	nduca 2013/07/09 23:07:19 i'd rather you have bear_webm.html rather than som i'd rather you have bear_webm.html rather than something that listens to query strigs. I believe I mentioned this previously. Otherwise, the user has to understand 3 different files and how they interact just to understand that this file plays bear.webm shadi 2013/07/11 00:49:13 As I mentioned in previous comments, this file is Show quoted text On 2013/07/09 23:07:19, nduca wrote: > i'd rather you have bear_webm.html rather than something that listens to query > strigs. I believe I mentioned this previously. Otherwise, the user has to > understand 3 different files and how they interact just to understand that this > file plays bear.webm As I mentioned in previous comments, this file is not the official video stack test cases. It serves more as an example as you can see it contains three video tags. However, I do anticipate we want to pass parameters through URL. We want to have a simple page that plays a video or audio file. Considering all codecs and types, it made sense to pass the media file by param instead of having 10 html files. I would rather have this discussion when landing video stack page sets CL later.
	10 var video = document.getElementById('video_1');

	11 if (mediaFile)

	12 video.src = mediaFile;

	13 </script>

	14 </body>

	15 </html>

OLD	NEW