tools/perf/page_sets/video_stack/video_stack.json - Issue 16854013: Telemetry media_measurement plus play action and tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/page_sets/video_stack/video_stack.json

Issue 16854013: Telemetry media_measurement plus play action and tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: removed un-needed file Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {
	nduca 2013/06/17 23:01:33 i think current custom is to call this file and fo i think current custom is to call this file and folder tough_video_cases, and put the json parallel to the directory. Copy tough scrolling cases. shadi 2013/06/18 00:30:01 Why did you guys go with tough__cases naming? Pag Show quoted text On 2013/06/17 23:01:33, nduca wrote: > i think current custom is to call this file and folder tough_video_cases, and > put the json parallel to the directory. Copy tough scrolling cases. Why did you guys go with tough__cases naming? Page sets don't have to be "tough". Is it a strict naming convention? Why "tough"? I like the folder & .json separation though.
	2 "description": "Video Stack Perf benchmark",

	3 "pages": [

	4 {

	5 "url": "file:///video.html?mediaFile=bear.webm",

	6 "media_metrics": [

	7 { "action": "play",

	8 "selector": "#video_1",

	9 "wait_for_playing": true,

	10 "wait_for_ended": true

	11 }

	12 ]

	13 }

	14 ]

	15 }

OLD	NEW