tools/telemetry/unittest_data/video_test.html - Issue 16854013: Telemetry media_measurement plus play action and tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/unittest_data/video_test.html

Issue 16854013: Telemetry media_measurement plus play action and tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <html>
	scherkus (not reviewing) 2013/06/14 20:50:45 <!DOCTYPE html> <!DOCTYPE html> shadi 2013/06/17 19:13:59 Done. Show quoted text On 2013/06/14 20:50:45, scherkus wrote: > <!DOCTYPE html> Done.
	2 <body>

	3 <video id="video_1" src="bear.webm" controls></video>
	scherkus (not reviewing) 2013/06/14 20:50:45 nit: in your other html pages you don't use a "_" nit: in your other html pages you don't use a "_" for the IDs my $0.02 would be to try and be consistent w/ naming shadi 2013/06/17 19:13:59 Done. Show quoted text On 2013/06/14 20:50:45, scherkus wrote: > nit: in your other html pages you don't use a "_" for the IDs > > my $0.02 would be to try and be consistent w/ naming Done.
	4 <video id="video_2" src="bear.webm" controls></video>

	5 </body>

	6 <script type="text/javascript">
	scherkus (not reviewing) 2013/06/14 20:50:45 script can go in body script can go in body shadi 2013/06/17 19:13:59 Done. Show quoted text On 2013/06/14 20:50:45, scherkus wrote: > script can go in body Done.
	7 var videos = document.getElementsByTagName('video');
	scherkus (not reviewing) 2013/06/14 20:50:45 what is the point of this statement? is some other what is the point of this statement? is some other script/test interacting with this variable? shadi 2013/06/17 19:13:59 Not really. I added it when I was thinking of othe Show quoted text On 2013/06/14 20:50:45, scherkus wrote: > what is the point of this statement? is some other script/test interacting with > this variable? Not really. I added it when I was thinking of other unit tests I was going to add.
	8 </script>

	9 </html>

OLD	NEW

« tools/telemetry/telemetry/page/actions/play.py ('K') | « tools/telemetry/unittest_data/bear.webm ('k') | no next file » | no next file with comments »