Issue 16854009: another attempt at fixing 15107

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16854009: another attempt at fixing 15107 (Closed)

Created:
7 years, 6 months ago by dcarney

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	src/api.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

dcarney

Committed patchset #1 manually as r15112 (presubmit successful).

7 years, 6 months ago (2013-06-13 10:39:51 UTC) #1

Sven Panne

7 years, 6 months ago (2013-06-13 10:49:12 UTC) #2

Message was sent while issue was closed.

LGTM. Just for the record: The previous fix worked locally, but not on the bots,
for whatever reason...