third_party/WebKit/Source/bindings/scripts/v8_methods.py - Issue 1685393002: [Experimental Framework] Rename IDL attribute to OriginTrialEnabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_methods.py

Issue 1685393002: [Experimental Framework] Rename IDL attribute to OriginTrialEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_attributes.py ('K') | « third_party/WebKit/Source/bindings/scripts/v8_interface.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_methods.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_methods.py b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

index 35696ea727eb379d7c10319ed237fe7ed46f53ae..6277ad0d5c67dfdae60fad5eea505cd104a5ddd5 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_methods.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

@@ -118,7 +118,7 @@ def method_context(interface, method, is_visible=True):

if 'LenientThis' in extended_attributes:

raise Exception('[LenientThis] is not supported for operations.')

- if 'APIExperimentEnabled' in extended_attributes:

+ if 'OriginTrialEnabled' in extended_attributes:

includes.add('core/inspector/ConsoleMessage.h')

includes.add('core/origin_trials/OriginTrials.h')

@@ -128,8 +128,8 @@ def method_context(interface, method, is_visible=True):

return {

'activity_logging_world_list': v8_utilities.activity_logging_world_list(method), # [ActivityLogging]

- 'api_experiment_enabled': v8_utilities.api_experiment_enabled_function(method), # [APIExperimentEnabled]

- 'api_experiment_enabled_per_interface': v8_utilities.api_experiment_enabled_function(interface), # [APIExperimentEnabled]

+ 'origin_trial_enabled': v8_utilities.origin_trial_enabled_function(method), # [OriginTrialEnabled]

+ 'origin_trial_enabled_per_interface': v8_utilities.origin_trial_enabled_function(interface), # [OriginTrialEnabled]

'arguments': argument_contexts,

'argument_declarations_for_private_script':

argument_declarations_for_private_script(interface, method),

@@ -157,7 +157,7 @@ def method_context(interface, method, is_visible=True):

any(True for argument_context in argument_contexts

if argument_context['is_optional_without_default_value']),

'idl_type': idl_type.base_type,

- 'is_api_experiment_enabled': v8_utilities.api_experiment_enabled_function(method) or v8_utilities.api_experiment_enabled_function(interface), # [APIExperimentEnabled]

+ 'is_origin_trial_enabled': v8_utilities.origin_trial_enabled_function(method) or v8_utilities.origin_trial_enabled_function(interface), # [OriginTrialEnabled]

'is_call_with_execution_context': has_extended_attribute_value(method, 'CallWith', 'ExecutionContext'),

'is_call_with_script_arguments': is_call_with_script_arguments,

'is_call_with_script_state': is_call_with_script_state,