Chromium Code Reviews Chromium Code Reviews
Issue 1685393002:
[Experimental Framework] Rename IDL attribute to OriginTrialEnabled (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 {% macro v8_value_to_local_cpp_value(thing) %} | 1 {% macro v8_value_to_local_cpp_value(thing) %} |
| 2 {# This indirection is just to avoid spurious white-space lines. #} | 2 {# This indirection is just to avoid spurious white-space lines. #} |
| 3 {{generate_v8_value_to_local_cpp_value(thing) | trim}} | 3 {{generate_v8_value_to_local_cpp_value(thing) | trim}} |
| 4 {%- endmacro %} | 4 {%- endmacro %} |
| 5 | 5 |
| 6 | 6 |
| 7 {% macro generate_v8_value_to_local_cpp_value(thing) %} | 7 {% macro generate_v8_value_to_local_cpp_value(thing) %} |
| 8 {% set item = thing.v8_value_to_local_cpp_value or thing %} | 8 {% set item = thing.v8_value_to_local_cpp_value or thing %} |
| 9 {% if item.error_message %} | 9 {% if item.error_message %} |
| 10 /* {{item.error_message}} */ | 10 /* {{item.error_message}} */ |
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 48 {% if member.on_prototype %} | 48 {% if member.on_prototype %} |
| 49 {% set property_location_list = property_location_list + ['V8DOMConfiguration::O nPrototype'] %} | 49 {% set property_location_list = property_location_list + ['V8DOMConfiguration::O nPrototype'] %} |
| 50 {% endif %} | 50 {% endif %} |
| 51 {% if member.on_interface %} | 51 {% if member.on_interface %} |
| 52 {% set property_location_list = property_location_list + ['V8DOMConfiguration::O nInterface'] %} | 52 {% set property_location_list = property_location_list + ['V8DOMConfiguration::O nInterface'] %} |
| 53 {% endif %} | 53 {% endif %} |
| 54 {{property_location_list | join(' | ')}} | 54 {{property_location_list | join(' | ')}} |
| 55 {%- endmacro %} | 55 {%- endmacro %} |
| 56 | 56 |
| 57 | 57 |
| 58 {% macro check_api_experiment_internal(errorName, experiment_name) %} | 58 {% macro check_origin_trial_internal(errorName, experiment_name) %} |
|
chasej
2016/02/11 20:01:50
Should rename experiment_name, as in earlier comme
iclelland
2016/02/11 21:37:36
Done.
| |
| 59 {% if experiment_name %} | 59 {% if experiment_name %} |
| 60 String {{errorName}}; | 60 String {{errorName}}; |
| 61 if (!{{experiment_name}}(executionContext, {{errorName}})) { | 61 if (!{{experiment_name}}(executionContext, {{errorName}})) { |
| 62 v8SetReturnValue(info, v8::Undefined(info.GetIsolate())); | 62 v8SetReturnValue(info, v8::Undefined(info.GetIsolate())); |
| 63 if (!{{errorName}}.isEmpty()) { | 63 if (!{{errorName}}.isEmpty()) { |
| 64 toDocument(executionContext)->addConsoleMessage(ConsoleMessage::create( JSMessageSource, ErrorMessageLevel, {{errorName}})); | 64 toDocument(executionContext)->addConsoleMessage(ConsoleMessage::create( JSMessageSource, ErrorMessageLevel, {{errorName}})); |
| 65 } | 65 } |
| 66 return; | 66 return; |
| 67 } | 67 } |
| 68 {% endif %} | 68 {% endif %} |
| 69 {% endmacro %} | 69 {% endmacro %} |
| 70 | 70 |
| 71 | 71 |
| 72 {% macro check_api_experiment(member, isolate="info.GetIsolate()") -%} | 72 {% macro check_origin_trial(member, isolate="info.GetIsolate()") -%} |
| 73 ExecutionContext* executionContext = currentExecutionContext({{isolate}}); | 73 ExecutionContext* executionContext = currentExecutionContext({{isolate}}); |
| 74 {{check_api_experiment_internal("errorMessage", member.api_experiment_enabled_pe r_interface) -}} | 74 {{check_origin_trial_internal("errorMessage", member.origin_trial_enabled_per_in terface) -}} |
| 75 {{check_api_experiment_internal("memberErrorMessage", member.api_experiment_enab led) -}} | 75 {{check_origin_trial_internal("memberErrorMessage", member.origin_trial_enabled) -}} |
| 76 {% endmacro %} | 76 {% endmacro %} |
| OLD | NEW |
