Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1685343004: Don't call WebContents::DownloadImage() callback if the WebContents were deleted (Closed)

Created:
4 years, 10 months ago by pkotwicz
Modified:
4 years, 10 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't call WebContents::DownloadImage() callback if the WebContents were deleted BUG=583718 Committed: https://crrev.com/75ca8ffd7bd7c58ace1144df05e1307d8d707662 Cr-Commit-Position: refs/heads/master@{#375700}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M content/browser/web_contents/web_contents_impl.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 5 chunks +25 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
rockot@ can you please take a look? I cannot reproduce the use-after-free locally. However, this ...
4 years, 10 months ago (2016-02-11 04:34:32 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 10 months ago (2016-02-12 19:42:25 UTC) #3
pkotwicz
jam@ can you please take a look?
4 years, 10 months ago (2016-02-12 19:45:34 UTC) #5
jam
lgtm with comments https://codereview.chromium.org/1685343004/diff/1/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/1685343004/diff/1/content/browser/web_contents/web_contents_impl.cc#newcode4620 content/browser/web_contents/web_contents_impl.cc:4620: DCHECK(result); this is unnecessary. in release ...
4 years, 10 months ago (2016-02-12 23:31:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685343004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685343004/20001
4 years, 10 months ago (2016-02-16 21:49:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 23:10:26 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 23:12:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75ca8ffd7bd7c58ace1144df05e1307d8d707662
Cr-Commit-Position: refs/heads/master@{#375700}

Powered by Google App Engine
This is Rietveld 408576698