fixes #25740, substitute type parameter bound taking into account outer scope type params

fixes #25740, substitute type parameter bound taking into account outer scope type params

FunctionTypeImpl's "typeFormals" now works like its "parameters". typeFormals now propagates the substitution down to the List<TypeParameterElement>, like we already did for List<ParameterElement>.

R=brianwilkerson@google.com, leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/66e1a1d5f2cade6953a6202d7c9ec00ad7101b66

[Jennifer Messerly, 2016-02-10 21:39:39]

Description was changed from

==========
fixes #25740, substitute type parameter bound taking into account outer scope
type params
==========

to

==========
fixes #25740, substitute type parameter bound taking into account outer scope
type params

FunctionTypeImpl's "typeFormals" now works like its "parameters". typeFormals
now propagates the substitution down to the List<TypeParameterElement>, like we
already did for List<ParameterElement>.
==========

[Jennifer Messerly, 2016-02-10 21:39:39]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com

[Jennifer Messerly, 2016-02-10 21:42:18]

https://codereview.chromium.org/1685273002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1685273002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1727: test('infer
generic method type', () {
moved 2 tests so they're in the right group.

https://codereview.chromium.org/1685273002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1777: test('null
literal should not infer as bottom', () {
this test is unchanged, it just moved to the bottom (the fact that it's testing
⊥ is entirely coincidental :) ).

[Brian Wilkerson, 2016-02-10 22:55:46]

LGTM

https://codereview.chromium.org/1685273002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/member.dart (right):

https://codereview.chromium.org/1685273002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/member.dart:943: static TypeParameterElement
from(
nit: I think our sorter sorts static methods to the top, so I'm guessing this
needs to be sorted.

[Leaf, 2016-02-11 19:18:12]

lgtm

[Jennifer Messerly, 2016-02-11 20:13:16]

Thanks!

https://codereview.chromium.org/1685273002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/member.dart (right):

https://codereview.chromium.org/1685273002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/member.dart:943: static TypeParameterElement
from(
On 2016/02/10 22:55:46, Brian Wilkerson wrote:
> nit: I think our sorter sorts static methods to the top, so I'm guessing this
> needs to be sorted.

Hmmm. It seems to think the file is already sorted. I did sort it to get it to
move TypeParameterMember to the right place.

[Jennifer Messerly, 2016-02-11 20:13:24]

Description was changed from

==========
fixes #25740, substitute type parameter bound taking into account outer scope
type params

FunctionTypeImpl's "typeFormals" now works like its "parameters". typeFormals
now propagates the substitution down to the List<TypeParameterElement>, like we
already did for List<ParameterElement>.
==========

to

==========
fixes #25740, substitute type parameter bound taking into account outer scope
type params

FunctionTypeImpl's "typeFormals" now works like its "parameters". typeFormals
now propagates the substitution down to the List<TypeParameterElement>, like we
already did for List<ParameterElement>.

R=brianwilkerson@google.com, leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/66e1a1d5f2cade6953a6202d7c9ec00ad7101b66
==========

[Jennifer Messerly, 2016-02-11 20:13:25]

Committed patchset #2 (id:20001) manually as
66e1a1d5f2cade6953a6202d7c9ec00ad7101b66 (presubmit successful).