pkg/analyzer/tool/summary/generate.dart - Issue 1685263003: Minor improvements to list representation in flatbuffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/tool/summary/generate.dart

Issue 1685263003: Minor improvements to list representation in flatbuffers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add a test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/tool/summary/generate.dart

diff --git a/pkg/analyzer/tool/summary/generate.dart b/pkg/analyzer/tool/summary/generate.dart

index 5c2d2bfaabd181ce7997221188144e9c87027ce8..64fb1f676eea1a7188ea7fae78b5835b6f1535cd 100644

--- a/pkg/analyzer/tool/summary/generate.dart

+++ b/pkg/analyzer/tool/summary/generate.dart

@@ -545,8 +545,7 @@ class _CodeGenerator {

String def = defaultValue(type, false);

if (type.isList) {

if (typeName == 'int') {

- String itemCode = 'const fb.Uint32Reader()';

- readCode = 'const fb.ListReader<int>($itemCode)';

+ readCode = 'const fb.Uint32ListReader()';

} else if (typeName == 'double') {

readCode = 'const fb.Float64ListReader()';

} else if (typeName == 'String') {

« no previous file with comments | « pkg/analyzer/test/src/summary/flat_buffers_test.dart ('k') | no next file » | no next file with comments »