Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1685263003: Minor improvements to list representation in flatbuffers. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Minor improvements to list representation in flatbuffers. This CL makes the following changes: - Renames _FbInt32List to _FbGenericList, and makes it able to represent lists of entities whose size isn't 4. - Adds Uint32ListReader and _FbUint32List classes, which are specialized to handle lists of 32-bit unsigned ints. - Moves common elements of all _Fb*List classes to the _FbList base class. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/71b593f89e295e5684b5d7db76e2b365e97213f1

Patch Set 1 #

Patch Set 2 : Add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -28 lines) Patch
M pkg/analyzer/lib/src/summary/flat_buffers.dart View 6 chunks +52 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/flat_buffers_test.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-11 19:46:35 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-11 20:01:26 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-11 20:14:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
71b593f89e295e5684b5d7db76e2b365e97213f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698