ARM32 vector lowering: fabs, scalarize remaining arithmetic operations.

pydir/crosstest.py

 #!/usr/bin/env python2
 
 import argparse
 import os
 import subprocess
 import sys
 import tempfile
 
 import targets
 from szbuild import LinkNonsfi
@@ skipping 11 matching lines @@
     the test functions with a variety of interesting inputs and compares their
     results.
 
     """
     # arch_map maps a Subzero target string to TargetInfo (e.g., triple).
     arch_map = { 'x8632': targets.X8632Target,
                  'x8664': targets.X8664Target,
                  'arm32': targets.ARM32Target }
     arch_sz_flags = { 'x8632': [],
                       'x8664': [],
-                      # TODO(jvoung): remove skip-unimplemented when
-                      # implemented.
                       # For ARM, test a large stack offset as well, until we
                       # are more confident. +/- 4095 is the limit, so test

[Jim Stichnoth, 2016/02/17 20:59:51]

While you're at it, I would reword this comment a bit.

I think we're plenty confident by now, but we might as well retain this flag to
get better test coverage.  So maybe this:

# For ARM, test a large stack offset as well, to increase coverage on that code
path.  +/- 4096 is ...

[Eric Holk, 2016/02/17 22:31:56]

Done.

                       # somewhere near that boundary.
-                      'arm32': ['--skip-unimplemented',
-                                '--test-stack-extra', '4084']
+                      'arm32': ['--test-stack-extra', '4084']
     }
     arch_llc_flags_extra = {
         # Use sse2 instructions regardless of input -mattr
         # argument to avoid differences in (undefined) behavior of
         # converting NaN to int.
         'x8632': ['-mattr=sse2'],
         'x8664': ['-mattr=sse2'],
         'arm32': [],
     }
     desc = 'Build a cross-test that compares Subzero and llc translation.'
@@ skipping 214 matching lines @@
     objs.append(obj_llc)
     if args.nonsfi:
         LinkNonsfi(objs, os.path.join(args.dir, args.output), args.target)
     elif args.sandbox:
         LinkSandbox(objs, os.path.join(args.dir, args.output), args.target)
     else:
         LinkNative(objs, os.path.join(args.dir, args.output), args.target)
 
 if __name__ == '__main__':
     main()