Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7554)

Unified Diff: chrome/test/kasko/hang_watcher_integration_test.py

Issue 1685233002: Fix the Kasko GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/kasko/hang_watcher_integration_test.py
diff --git a/chrome/test/kasko/hang_watcher_integration_test.py b/chrome/test/kasko/hang_watcher_integration_test.py
index 345a2408bcb909d4e2f48f70a5c1719eaabe4efb..b6064fe4b6d68d900a4d377c13acfbdcb2a0749e 100755
--- a/chrome/test/kasko/hang_watcher_integration_test.py
+++ b/chrome/test/kasko/hang_watcher_integration_test.py
@@ -14,13 +14,20 @@ of Chrome with Chrome branding, and attempting to use it with anything else will
most likely lead to constant failures.
Typical usage (assuming in root 'src' directory):
-
-- generate project files with the following GYP variables:
- branding=Chrome kasko=1 kasko_hang_reports=1
+- generate project files with the following build variables:
+ GYP variables:
+ branding=Chrome kasko=1 kasko_hang_reports=1
+ GN variables:
+ target_cpu = "x86"
+ is_debug = false
+ is_chrome_branded = true
+ enable_kasko = true
+ enable_kasko_hang_reports = true
- build the release Chrome binaries:
- ninja -C out\Release chrome.exe chromedriver.exe
+ ninja -C {build_dir} chrome.exe chromedriver.exe
- run the test:
python chrome/test/kasko/hang_watcher_integration_test.py
+ --chrome={build_dir}\chrome.exe
"""
import logging
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698