Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1685233002: Fix the Kasko GN build. (Closed)

Created:
4 years, 10 months ago by Patrick Monette
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the Kasko GN build. Committed: https://crrev.com/4745047a22b69623a37e3fece56c2c07a3398602 Cr-Commit-Position: refs/heads/master@{#374765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/chrome_watcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/kasko/hang_watcher_integration_test.py View 1 chunk +11 lines, -4 lines 0 comments Download
M components/crash/content/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Patrick Monette
Please review your assigned file! chrisha@ hang_watcher_integration_test.py siggi@ chrome/chrome_watcher/BUILD.gn scottmg@ components/crash/content/app/BUILD.gn
4 years, 10 months ago (2016-02-10 21:01:03 UTC) #2
Patrick Monette
Forgot to add reviewers
4 years, 10 months ago (2016-02-10 21:01:48 UTC) #4
scottmg
lgtm
4 years, 10 months ago (2016-02-10 21:04:22 UTC) #5
Sigurður Ásgeirsson
lgtm
4 years, 10 months ago (2016-02-10 22:11:06 UTC) #6
chrisha
lgtm
4 years, 10 months ago (2016-02-10 22:11:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685233002/1
4 years, 10 months ago (2016-02-10 22:14:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 23:01:06 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:07 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4745047a22b69623a37e3fece56c2c07a3398602
Cr-Commit-Position: refs/heads/master@{#374765}

Powered by Google App Engine
This is Rietveld 408576698