content/renderer/devtools/render_widget_screen_metrics_emulator.cc - Issue 1685213002: Propagate window coordinates to out-of-process iframes renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/render_widget_screen_metrics_emulator.cc

Issue 1685213002: Propagate window coordinates to out-of-process iframes renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sendscreenrects

Patch Set: addressing comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/devtools/render_widget_screen_metrics_emulator.h ('K') | « content/renderer/devtools/render_widget_screen_metrics_emulator.h ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/devtools/render_widget_screen_metrics_emulator.cc

diff --git a/content/renderer/devtools/render_widget_screen_metrics_emulator.cc b/content/renderer/devtools/render_widget_screen_metrics_emulator.cc

index 1022c27c29e91b3e715f9e10f31c50e1191948c5..d7d83978f09bd5abb03f67ef9bbeafdc5c4201d5 100644

--- a/content/renderer/devtools/render_widget_screen_metrics_emulator.cc

+++ b/content/renderer/devtools/render_widget_screen_metrics_emulator.cc

@@ -140,6 +140,14 @@ void RenderWidgetScreenMetricsEmulator::OnResize(const ResizeParams& params) {

delegate_->Redraw();

}

+void RenderWidgetScreenMetricsEmulator::OnUpdateWindowScreenRectMessage(

+ const gfx::Rect& window_screen_rect) {

+ original_window_screen_rect_ = window_screen_rect;

+ if (emulation_params_.screenPosition ==

+ blink::WebDeviceEmulationParams::Desktop)

+ Apply();

void RenderWidgetScreenMetricsEmulator::OnUpdateScreenRects(

const gfx::Rect& view_screen_rect,

const gfx::Rect& window_screen_rect) {