 Chromium Code Reviews
 Chromium Code Reviews Issue 1685213002:
  Propagate window coordinates to out-of-process iframes renderers.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@sendscreenrects
    
  
    Issue 1685213002:
  Propagate window coordinates to out-of-process iframes renderers.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@sendscreenrects| OLD | NEW | 
|---|---|
| 1 // Copyright 2013 The Chromium Authors. All rights reserved. | 1 // Copyright 2013 The Chromium Authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #include "content/renderer/render_frame_impl.h" | 5 #include "content/renderer/render_frame_impl.h" | 
| 6 | 6 | 
| 7 #include <map> | 7 #include <map> | 
| 8 #include <string> | 8 #include <string> | 
| 9 #include <utility> | 9 #include <utility> | 
| 10 #include <vector> | 10 #include <vector> | 
| (...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 46 #include "content/child/web_url_request_util.h" | 46 #include "content/child/web_url_request_util.h" | 
| 47 #include "content/child/webmessageportchannel_impl.h" | 47 #include "content/child/webmessageportchannel_impl.h" | 
| 48 #include "content/child/websocket_bridge.h" | 48 #include "content/child/websocket_bridge.h" | 
| 49 #include "content/child/weburlresponse_extradata_impl.h" | 49 #include "content/child/weburlresponse_extradata_impl.h" | 
| 50 #include "content/common/accessibility_messages.h" | 50 #include "content/common/accessibility_messages.h" | 
| 51 #include "content/common/clipboard_messages.h" | 51 #include "content/common/clipboard_messages.h" | 
| 52 #include "content/common/frame_messages.h" | 52 #include "content/common/frame_messages.h" | 
| 53 #include "content/common/frame_replication_state.h" | 53 #include "content/common/frame_replication_state.h" | 
| 54 #include "content/common/input_messages.h" | 54 #include "content/common/input_messages.h" | 
| 55 #include "content/common/navigation_params.h" | 55 #include "content/common/navigation_params.h" | 
| 56 #include "content/common/page_messages.h" | |
| 56 #include "content/common/savable_subframe.h" | 57 #include "content/common/savable_subframe.h" | 
| 57 #include "content/common/service_worker/service_worker_types.h" | 58 #include "content/common/service_worker/service_worker_types.h" | 
| 58 #include "content/common/site_isolation_policy.h" | 59 #include "content/common/site_isolation_policy.h" | 
| 59 #include "content/common/ssl_status_serialization.h" | 60 #include "content/common/ssl_status_serialization.h" | 
| 60 #include "content/common/swapped_out_messages.h" | 61 #include "content/common/swapped_out_messages.h" | 
| 61 #include "content/common/view_messages.h" | 62 #include "content/common/view_messages.h" | 
| 62 #include "content/public/common/bindings_policy.h" | 63 #include "content/public/common/bindings_policy.h" | 
| 63 #include "content/public/common/browser_side_navigation_policy.h" | 64 #include "content/public/common/browser_side_navigation_policy.h" | 
| 64 #include "content/public/common/content_constants.h" | 65 #include "content/public/common/content_constants.h" | 
| 65 #include "content/public/common/content_switches.h" | 66 #include "content/public/common/content_switches.h" | 
| (...skipping 1278 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1344 | 1345 | 
| 1345 #if defined(OS_MACOSX) || defined(OS_ANDROID) | 1346 #if defined(OS_MACOSX) || defined(OS_ANDROID) | 
| 1346 void RenderFrameImpl::DidHideExternalPopupMenu() { | 1347 void RenderFrameImpl::DidHideExternalPopupMenu() { | 
| 1347 // We need to clear external_popup_menu_ as soon as ExternalPopupMenu::close | 1348 // We need to clear external_popup_menu_ as soon as ExternalPopupMenu::close | 
| 1348 // is called. Otherwise, createExternalPopupMenu() for new popup will fail. | 1349 // is called. Otherwise, createExternalPopupMenu() for new popup will fail. | 
| 1349 external_popup_menu_.reset(); | 1350 external_popup_menu_.reset(); | 
| 1350 } | 1351 } | 
| 1351 #endif | 1352 #endif | 
| 1352 | 1353 | 
| 1353 bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) { | 1354 bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) { | 
| 1355 // Forward Page IPCs to the RenderView. | |
| 1356 if ((IPC_MESSAGE_CLASS(msg) == PageMsgStart) && render_view()) | |
| 
nasko
2016/02/12 18:14:08
If there is no render_view(), this will deliver th
 
lfg
2016/03/02 18:29:08
Yes, you are right. Changed.
 | |
| 1357 return render_view()->OnMessageReceived(msg); | |
| 1358 | |
| 1354 // We may get here while detaching, when the WebFrame has been deleted. Do | 1359 // We may get here while detaching, when the WebFrame has been deleted. Do | 
| 1355 // not process any messages in this state. | 1360 // not process any messages in this state. | 
| 1356 if (!frame_) | 1361 if (!frame_) | 
| 1357 return false; | 1362 return false; | 
| 1358 | 1363 | 
| 1359 // TODO(kenrb): document() should not be null, but as a transitional step | 1364 // TODO(kenrb): document() should not be null, but as a transitional step | 
| 1360 // we have RenderFrameProxy 'wrapping' a RenderFrameImpl, passing messages | 1365 // we have RenderFrameProxy 'wrapping' a RenderFrameImpl, passing messages | 
| 1361 // to this method. This happens for a top-level remote frame, where a | 1366 // to this method. This happens for a top-level remote frame, where a | 
| 1362 // document-less RenderFrame is replaced by a RenderFrameProxy but kept | 1367 // document-less RenderFrame is replaced by a RenderFrameProxy but kept | 
| 1363 // around and is still able to receive messages. | 1368 // around and is still able to receive messages. | 
| (...skipping 4760 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 6124 int match_count, | 6129 int match_count, | 
| 6125 int ordinal, | 6130 int ordinal, | 
| 6126 const WebRect& selection_rect, | 6131 const WebRect& selection_rect, | 
| 6127 bool final_status_update) { | 6132 bool final_status_update) { | 
| 6128 Send(new FrameHostMsg_Find_Reply(routing_id_, request_id, match_count, | 6133 Send(new FrameHostMsg_Find_Reply(routing_id_, request_id, match_count, | 
| 6129 selection_rect, ordinal, | 6134 selection_rect, ordinal, | 
| 6130 final_status_update)); | 6135 final_status_update)); | 
| 6131 } | 6136 } | 
| 6132 | 6137 | 
| 6133 } // namespace content | 6138 } // namespace content | 
| OLD | NEW |