Propagate window coordinates to out-of-process iframes renderers.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 27 matching lines @@
 #include "content/browser/dom_storage/session_storage_namespace_impl.h"
 #include "content/browser/download/download_stats.h"
 #include "content/browser/download/mhtml_generation_manager.h"
 #include "content/browser/download/save_package.h"
 #include "content/browser/frame_host/cross_process_frame_connector.h"
 #include "content/browser/frame_host/interstitial_page_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/frame_host/navigation_handle_impl.h"
 #include "content/browser/frame_host/navigator_impl.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
+#include "content/browser/frame_host/render_frame_proxy_host.h"
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
 #include "content/browser/geolocation/geolocation_service_context.h"
 #include "content/browser/host_zoom_map_impl.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/manifest/manifest_manager_host.h"
 #include "content/browser/media/audio_stream_monitor.h"
 #include "content/browser/media/capture/web_contents_audio_muter.h"
 #include "content/browser/media/media_web_contents_observer.h"
 #include "content/browser/message_port_message_filter.h"
 #include "content/browser/plugin_content_origin_whitelist.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_delegate_view.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_input_event_router.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/wake_lock/wake_lock_service_context.h"
 #include "content/browser/web_contents/web_contents_view_guest.h"
 #include "content/browser/webui/generic_handler.h"
 #include "content/browser/webui/web_ui_controller_factory_registry.h"
 #include "content/browser/webui/web_ui_impl.h"
 #include "content/common/browser_plugin/browser_plugin_constants.h"
 #include "content/common/browser_plugin/browser_plugin_messages.h"
 #include "content/common/frame_messages.h"
 #include "content/common/input_messages.h"
+#include "content/common/page_messages.h"
 #include "content/common/site_isolation_policy.h"
 #include "content/common/ssl_status_serialization.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/ax_event_notification_details.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_plugin_guest_manager.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/download_url_parameters.h"
@@ skipping 698 matching lines @@
   for (RenderFrameHost* rfh : GetAllFrames()) {
     ++number_of_messages;
     IPC::Message* message_copy = new IPC::Message(*message);
     message_copy->set_routing_id(rfh->GetRoutingID());
     rfh->Send(message_copy);
   }
   delete message;
   return number_of_messages;
 }
 
+int WebContentsImpl::SendToAllViews(IPC::Message* msg) {

[nasko, 2016/02/11 18:21:28]

Sending to all "Views" sounds like the wrong abstraction. We are sending a Page
message and it is an implementation detail that we can have multiple objects for
the same Page in different processes. SendPageMsg?

[lfg, 2016/02/11 20:26:09]

Done.

+  DCHECK(IPC_MESSAGE_CLASS(*msg) == PageMsgStart);
+  const auto& proxies =
+      frame_tree_.root()->render_manager()->GetAllProxyHosts();

[nasko, 2016/02/11 18:21:28]

I'd avoid exposing the proxies from RFHM. This method here can just be a caller
of RFHM::SendToAll or something similar, which then will hide the implementation
details of RFPH map and the rest.

[lfg, 2016/02/11 20:26:09]

Done.

+
+  for (const auto& pair : proxies) {
+    RenderFrameProxyHost* proxy = pair.second.get();
+
+    IPC::Message* copy = new IPC::Message(*msg);
+    copy->set_routing_id(proxy->GetRoutingID());
+    proxy->Send(copy);
+  }
+
+  RenderFrameHost* frame_host =
+      frame_tree_.root()->render_manager()->current_frame_host();

[nasko, 2016/02/11 18:21:28]

If we have a pending/speculative RFH, shouldn't we be sending it to that one as
well?

[lfg, 2016/02/11 20:26:08]

Yes, we should, because if/when we commit, we need that information to be up to
date. Fixed that.

+  msg->set_routing_id(frame_host->GetRoutingID());
+  frame_host->Send(msg);
+
+  return 1 + proxies.size();
+}
+
 RenderViewHostImpl* WebContentsImpl::GetRenderViewHost() const {
   return GetRenderManager()->current_host();
 }
 
 int WebContentsImpl::GetRoutingID() const {
   if (!GetRenderViewHost())
     return MSG_ROUTING_NONE;
 
   return GetRenderViewHost()->GetRoutingID();
 }
@@ skipping 1407 matching lines @@
 void WebContentsImpl::OnMoveValidationMessage(
     const gfx::Rect& anchor_in_root_view) {
   if (delegate_)
     delegate_->MoveValidationMessage(this, anchor_in_root_view);
 }
 
 void WebContentsImpl::SendScreenRects() {
   RenderWidgetHostImpl::From(GetRenderViewHost()->GetWidget())
       ->SendScreenRects();
 
+  RenderWidgetHostViewBase* rwhv =
+      static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
+  if (rwhv) {
+    SendToAllViews(new PageMsg_UpdateWindowScreenRect(
+        MSG_ROUTING_NONE, rwhv->GetBoundsInRootWindow()));
+  }
+
   if (browser_plugin_embedder_)
     browser_plugin_embedder_->DidSendScreenRects();
 }
 
 BrowserAccessibilityManager*
     WebContentsImpl::GetRootBrowserAccessibilityManager() {
   RenderFrameHostImpl* rfh = GetMainFrame();
   return rfh ? rfh->browser_accessibility_manager() : nullptr;
 }
 
@@ skipping 2525 matching lines @@
     const WebContentsObserver::MediaPlayerId& id) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, MediaStartedPlaying(id));
 }
 
 void WebContentsImpl::MediaStoppedPlaying(
     const WebContentsObserver::MediaPlayerId& id) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, MediaStoppedPlaying(id));
 }
 
 }  // namespace content