net/data/name_constraints_unittest/san-excluded-ipaddress.pem - Issue 1685023002: Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param and ParseExtension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/name_constraints_unittest/san-excluded-ipaddress.pem

Issue 1685023002: Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param and ParseExtension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@name-constraints-directorynameparsing

Patch Set: updated comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/name_constraints_unittest/san-excluded-dnsname.pem ('k') | net/data/name_constraints_unittest/san-invalid-empty.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/name_constraints_unittest/san-excluded-ipaddress.pem

diff --git a/net/data/name_constraints_unittest/san-excluded-ipaddress.pem b/net/data/name_constraints_unittest/san-excluded-ipaddress.pem

index 80d1f3f6c57ca5f14922dc4634ac9146418e6168..3616e7caae5fc0c579d266c8d732cacfa83f91c4 100644

--- a/net/data/name_constraints_unittest/san-excluded-ipaddress.pem

+++ b/net/data/name_constraints_unittest/san-excluded-ipaddress.pem

@@ -1,5 +1,18 @@

- 0:d=0 hl=2 l= 72 prim: OCTET STRING [HEX DUMP]:304682157065726D69747465642E6578616D706C652E636F6D8704C0A80102A421301F310B30090603550406130255533110300E06035504080C074172697A6F6E618704C0A80505

+ 0:d=0 hl=2 l= 70 cons: SEQUENCE

+ 2:d=1 hl=2 l= 21 prim: cont [ 2 ]

+ 25:d=1 hl=2 l= 4 prim: cont [ 7 ]

+ 31:d=1 hl=2 l= 33 cons: cont [ 4 ]

+ 33:d=2 hl=2 l= 31 cons: SEQUENCE

+ 35:d=3 hl=2 l= 11 cons: SET

+ 37:d=4 hl=2 l= 9 cons: SEQUENCE

+ 39:d=5 hl=2 l= 3 prim: OBJECT :countryName

+ 44:d=5 hl=2 l= 2 prim: PRINTABLESTRING :US

+ 48:d=3 hl=2 l= 16 cons: SET

+ 50:d=4 hl=2 l= 14 cons: SEQUENCE

+ 52:d=5 hl=2 l= 3 prim: OBJECT :stateOrProvinceName

+ 57:d=5 hl=2 l= 7 prim: UTF8STRING :Arizona

+ 66:d=1 hl=2 l= 4 prim: cont [ 7 ]

-----BEGIN SUBJECT ALTERNATIVE NAME-----

-BEgwRoIVcGVybWl0dGVkLmV4YW1wbGUuY29thwTAqAECpCEwHzELMAkGA1UEBhMCVVMxEDAOBgNV

-BAgMB0FyaXpvbmGHBMCoBQU=

+MEaCFXBlcm1pdHRlZC5leGFtcGxlLmNvbYcEwKgBAqQhMB8xCzAJBgNVBAYTAlVTMRAwDgYDVQQI

+DAdBcml6b25hhwTAqAUF

-----END SUBJECT ALTERNATIVE NAME-----