Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param and ParseExtension.

net/cert/internal/name_constraints.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_INTERNAL_NAME_CONSTRAINTS_H_
 #define NET_CERT_INTERNAL_NAME_CONSTRAINTS_H_
 
 #include <stdint.h>
 
 #include <vector>
@@ skipping 68 matching lines @@
   // the OCTET STRING tag). |is_critical| should be true if the extension was
   // marked critical. Returns nullptr if parsing the the extension failed.
   // The object lifetime is not bound to the lifetime of |extension_value| data.
   static scoped_ptr<NameConstraints> CreateFromDer(
       const der::Input& extension_value,
       bool is_critical);
 
   // Tests if a certificate is allowed by the name constraints.
   // |subject_rdn_sequence| should be the DER-encoded value of the subject's
   // RDNSequence (not including Sequence tag), and may be an empty ASN.1
   // sequence. |subject_alt_name_extnvalue_tlv| should be the extnValue of the

[eroman, 2016/02/10 17:30:09]

Update this line to reflect new variable name.

[mattm, 2016/02/10 22:48:40]

Done.

-  // subjectAltName extension (including the OCTET STRING tag & length), or
+  // subjectAltName extension (not including the OCTET STRING tag & length), or
   // empty if the cert did not have a subjectAltName extension.

[eroman, 2016/02/10 17:30:09]

This line also needs updating (since that is now conveyed by the bool)

[mattm, 2016/02/10 22:48:40]

Done.

   // Note that this method does not check hostname or IP address in commonName,
   // which is deprecated (crbug.com/308330).
   bool IsPermittedCert(const der::Input& subject_rdn_sequence,
-                       const der::Input& subject_alt_name_extnvalue_tlv) const;
+                       bool has_subject_alt_name,
+                       const der::Input& subject_alt_name_tlv) const;
 
   // Returns true if the ASCII hostname |name| is permitted.
   // |name| may be a wildcard hostname (starts with "*."). Eg, "*.bar.com"
   // would not be permitted if "bar.com" is permitted and "foo.bar.com" is
   // excluded, while "*.baz.com" would only be permitted if "baz.com" is
   // permitted.
   bool IsPermittedDNSName(const std::string& name) const;
 
   // Returns true if the directoryName |name_rdn_sequence| is permitted.
   // |name_rdn_sequence| should be the DER-encoded RDNSequence value (not
@@ skipping 23 matching lines @@
   bool Parse(const der::Input& extension_value,
              bool is_critical) WARN_UNUSED_RESULT;
 
   GeneralNames permitted_subtrees_;
   GeneralNames excluded_subtrees_;
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_INTERNAL_NAME_CONSTRAINTS_H_