Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: third_party/WebKit/Source/core/page/PagePopupSupplement.cpp

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/PagePopupSupplement.cpp
diff --git a/third_party/WebKit/Source/core/page/DOMWindowPagePopup.cpp b/third_party/WebKit/Source/core/page/PagePopupSupplement.cpp
similarity index 66%
rename from third_party/WebKit/Source/core/page/DOMWindowPagePopup.cpp
rename to third_party/WebKit/Source/core/page/PagePopupSupplement.cpp
index 6fe0de5671c302c38e9066b1c37da3e8f9896aff..59022be359d041e26ae9826b9c5b1ff3d5b5cd1a 100644
--- a/third_party/WebKit/Source/core/page/DOMWindowPagePopup.cpp
+++ b/third_party/WebKit/Source/core/page/PagePopupSupplement.cpp
@@ -28,49 +28,48 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#include "core/page/DOMWindowPagePopup.h"
+#include "core/page/PagePopupSupplement.h"
-#include "core/frame/LocalDOMWindow.h"
#include "core/page/PagePopupController.h"
namespace blink {
-DOMWindowPagePopup::DOMWindowPagePopup(PagePopup& popup, PagePopupClient* popupClient)
+PagePopupSupplement::PagePopupSupplement(PagePopup& popup, PagePopupClient* popupClient)
: m_controller(PagePopupController::create(popup, popupClient))
{
ASSERT(popupClient);
}
-DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(DOMWindowPagePopup);
+DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(PagePopupSupplement);
-const char* DOMWindowPagePopup::supplementName()
+const char* PagePopupSupplement::supplementName()
{
- return "DOMWindowPagePopup";
+ return "PagePopupSupplement";
}
-PagePopupController* DOMWindowPagePopup::pagePopupController(DOMWindow& window)
+PagePopupController* PagePopupSupplement::pagePopupController(LocalFrame& frame)
{
- DOMWindowPagePopup* supplement = static_cast<DOMWindowPagePopup*>(from(&toLocalDOMWindow(window), supplementName()));
+ PagePopupSupplement* supplement = static_cast<PagePopupSupplement*>(from(&frame, supplementName()));
ASSERT(supplement);
return supplement->m_controller.get();
}
-void DOMWindowPagePopup::install(LocalDOMWindow& window, PagePopup& popup, PagePopupClient* popupClient)
+void PagePopupSupplement::install(LocalFrame& frame, PagePopup& popup, PagePopupClient* popupClient)
{
ASSERT(popupClient);
- provideTo(window, supplementName(), adoptPtrWillBeNoop(new DOMWindowPagePopup(popup, popupClient)));
+ provideTo(frame, supplementName(), adoptPtrWillBeNoop(new PagePopupSupplement(popup, popupClient)));
}
-void DOMWindowPagePopup::uninstall(LocalDOMWindow& window)
+void PagePopupSupplement::uninstall(LocalFrame& frame)
{
- pagePopupController(window)->clearPagePopupClient();
- window.removeSupplement(supplementName());
+ pagePopupController(frame)->clearPagePopupClient();
+ frame.removeSupplement(supplementName());
}
-DEFINE_TRACE(DOMWindowPagePopup)
+DEFINE_TRACE(PagePopupSupplement)
{
visitor->trace(m_controller);
- WillBeHeapSupplement<LocalDOMWindow>::trace(visitor);
+ WillBeHeapSupplement<LocalFrame>::trace(visitor);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698