extensions/browser/app_window/app_window_contents.cc - Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window_contents.cc

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/app_window/app_window_contents.h ('k') | extensions/browser/app_window/test_app_window_contents.h » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/app_window/app_window_contents.cc

diff --git a/extensions/browser/app_window/app_window_contents.cc b/extensions/browser/app_window/app_window_contents.cc

index 7f1a7a1d00484bccdc0bbe8ded1cff641dbdb9a5..3cb0cb850de3f289aa460fa311a7ea026df77995 100644

--- a/extensions/browser/app_window/app_window_contents.cc

+++ b/extensions/browser/app_window/app_window_contents.cc

@@ -27,12 +27,15 @@ AppWindowContentsImpl::AppWindowContentsImpl(AppWindow* host)

AppWindowContentsImpl::~AppWindowContentsImpl() {}

void AppWindowContentsImpl::Initialize(content::BrowserContext* context,

+ content::RenderFrameHost* creator_frame,

const GURL& url) {

url_ = url;

- web_contents_.reset(

- content::WebContents::Create(content::WebContents::CreateParams(

- context, content::SiteInstance::CreateForURL(context, url_))));

+ content::WebContents::CreateParams create_params(

+ context, creator_frame->GetSiteInstance());

+ create_params.opener_render_process_id = creator_frame->GetProcess()->GetID();

+ create_params.opener_render_frame_id = creator_frame->GetRoutingID();

+ web_contents_.reset(content::WebContents::Create(create_params));

Observe(web_contents_.get());

web_contents_->GetMutableRendererPrefs()->