content/shell/renderer/layout_test/blink_test_runner.h - Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.h

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/blink_test_runner.h

diff --git a/content/shell/renderer/layout_test/blink_test_runner.h b/content/shell/renderer/layout_test/blink_test_runner.h

index fc5fe51d989e434e8da3070a31bc79f33f72ce7a..b2598fe28fa63cc7553b506c8229bc3fd6d54439 100644

--- a/content/shell/renderer/layout_test/blink_test_runner.h

+++ b/content/shell/renderer/layout_test/blink_test_runner.h

@@ -157,7 +157,12 @@ class BlinkTestRunner : public RenderViewObserver,

blink::WebPoint ConvertDIPToNative(

const blink::WebPoint& point_in_dip) const override;

- void Reset();

+ // Resets a RenderView to a known state for layout tests. It is used both when

+ // a RenderView is created and when reusing an existing RenderView for the

+ // next test case.

+ // When reusing an existing RenderView, |for_new_test| should be true, which

+ // also resets additional state, like the main frame's name and opener.

+ void Reset(bool for_new_test);

void set_proxy(test_runner::WebTestProxyBase* proxy) { proxy_ = proxy; }

test_runner::WebTestProxyBase* proxy() const { return proxy_; }