chrome/renderer/chrome_render_view_observer.h - Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_view_observer.h

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm ('k') | chrome/renderer/chrome_render_view_observer.cc » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_render_view_observer.h

diff --git a/chrome/renderer/chrome_render_view_observer.h b/chrome/renderer/chrome_render_view_observer.h

index cdc15f3ee76ee5d696fa3327e182e2b9468f3bb7..370ac31657ebfb9720fe169f9439594420344d32 100644

--- a/chrome/renderer/chrome_render_view_observer.h

+++ b/chrome/renderer/chrome_render_view_observer.h

@@ -42,7 +42,8 @@ class ChromeRenderViewObserver : public content::RenderViewObserver {

private:

// RenderViewObserver implementation.

bool OnMessageReceived(const IPC::Message& message) override;

- void DidStartLoading() override;

+ void DidCommitProvisionalLoad(blink::WebLocalFrame* frame,

+ bool is_new_navigation) override;

void Navigate(const GURL& url) override;

#if !defined(OS_ANDROID)