chrome/browser/ui/ash/accelerator_commands_browsertest.cc - Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/accelerator_commands_browsertest.cc

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/ui/ash/keyboard_controller_browsertest.cc » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/accelerator_commands_browsertest.cc

diff --git a/chrome/browser/ui/ash/accelerator_commands_browsertest.cc b/chrome/browser/ui/ash/accelerator_commands_browsertest.cc

index 43f339715501f8438886dc85d78403ac5c7746ab..7bc172e120b9ee6f4da30c8c6086dc81788bdd0a 100644

--- a/chrome/browser/ui/ash/accelerator_commands_browsertest.cc

+++ b/chrome/browser/ui/ash/accelerator_commands_browsertest.cc

@@ -280,7 +280,7 @@ IN_PROC_BROWSER_TEST_P(AcceleratorCommandsPlatformAppFullscreenBrowserTest,

extensions::AppWindow::CreateParams params;

params.frame = extensions::AppWindow::FRAME_CHROME;

extensions::AppWindow* app_window =

- CreateAppWindowFromParams(extension, params);

+ CreateAppWindowFromParams(browser()->profile(), extension, params);

extensions::NativeAppWindow* native_app_window =

app_window->GetBaseWindow();

SetToInitialShowState(app_window);

@@ -305,7 +305,7 @@ IN_PROC_BROWSER_TEST_P(AcceleratorCommandsPlatformAppFullscreenBrowserTest,