chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm - Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ALL THE TESTS. Hopefully. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc ('K') | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc ('k') | chrome/renderer/chrome_render_view_observer.h » ('j') | chrome/renderer/chrome_render_view_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm

diff --git a/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm b/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm

index 19ab345c6716b75f555de411867bfd98f5dd2310..72f333e2fa66c073ba7fbab0d46e6f37bfcd34da 100644

--- a/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm

+++ b/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm

@@ -46,7 +46,7 @@ class AppShimMenuControllerUITest : public extensions::PlatformAppBrowserTest {

// windows activate, because the test binary has a default activation policy

// of "prohibited".

app1_ = GetFirstAppWindow();

- app2_ = CreateAppWindow(extension);

+ app2_ = CreateAppWindow(browser()->profile(), extension);

browser1_ = browser()->window();

browser2_ = (new Browser(Browser::CreateParams(profile())))->window();

browser2_->Show();