third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp - Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make initSecurityContext private. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/app_window/app_window_contents.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

index b2a88bde3725a2030e7e1eea5b31914f25b0dc5b..bd3db2a6917dc4eccda42e0a97004c545a3e8ba0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

@@ -9,8 +9,8 @@

#include "core/dom/ContextFeatures.h"

#include "core/dom/Document.h"

#include "core/dom/ExecutionContext.h"

-#include "core/page/DOMWindowPagePopup.h"

#include "core/page/PagePopupController.h"

+#include "core/page/PagePopupSupplement.h"

#include "platform/TraceEvent.h"

namespace blink {

@@ -21,7 +21,7 @@ void pagePopupControllerAttributeGetter(const v8::PropertyCallbackInfo<v8::Value

{

v8::Local<v8::Object> holder = info.Holder();

DOMWindow* impl = V8Window::toImpl(holder);

- RefPtrWillBeRawPtr<PagePopupController> cppValue(DOMWindowPagePopup::pagePopupController(*impl));

+ RefPtrWillBeRawPtr<PagePopupController> cppValue(PagePopupSupplement::pagePopupController(*toLocalDOMWindow(impl)->frame()));

v8SetReturnValue(info, toV8(cppValue.get(), holder, info.GetIsolate()));

}