chrome/browser/apps/guest_view/web_view_browsertest.cc - Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make initSecurityContext private. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_browsertest_util.cc ('k') | content/renderer/render_frame_impl.h » ('j') | extensions/browser/app_window/app_window_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/guest_view/web_view_browsertest.cc

diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc

index 54645635bdece3348d4b6cb0b61e17c47d225d96..551e35d9eeb3918100afab4f250f59faa065af6c 100644

--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc

+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc

@@ -2047,14 +2047,9 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, ChromeVoxInjection) {

#define MAYBE_TearDownTest TearDownTest

#endif

IN_PROC_BROWSER_TEST_P(WebViewTest, MAYBE_TearDownTest) {

- const extensions::Extension* extension =

- LoadAndLaunchPlatformApp("web_view/simple", "WebViewTest.LAUNCHED");

- extensions::AppWindow* window = NULL;

- if (!GetAppWindowCount())

- window = CreateAppWindow(extension);

- else

- window = GetFirstAppWindow();

- CloseAppWindow(window);

+ LoadAndLaunchPlatformApp("web_view/simple", "WebViewTest.LAUNCHED");

+ ASSERT_TRUE(GetAppWindowCount());

+ CloseAppWindow(GetFirstAppWindow());

// Load the app again.

LoadAndLaunchPlatformApp("web_view/simple", "WebViewTest.LAUNCHED");