third_party/WebKit/public/web/WebLocalFrame.h - Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change page popup plumbing, remove vestigal bits related to failing security context init Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/SecurityContext.cpp ('K') | « third_party/WebKit/public/web/WebFrame.h ('k') | third_party/WebKit/public/web/WebRemoteFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/WebLocalFrame.h

diff --git a/third_party/WebKit/public/web/WebLocalFrame.h b/third_party/WebKit/public/web/WebLocalFrame.h

index ba4eb4e40c9fbf0e40f19163d927817a6614095f..57a6151fa2febcb071ceea24fc5c5ee5cf38cdc4 100644

--- a/third_party/WebKit/public/web/WebLocalFrame.h

+++ b/third_party/WebKit/public/web/WebLocalFrame.h

@@ -31,7 +31,7 @@ class WebLocalFrame : public WebFrame {

public:

// Creates a WebFrame. Delete this WebFrame by calling WebFrame::close().

// It is valid to pass a null client pointer.

- BLINK_EXPORT static WebLocalFrame* create(WebTreeScopeType, WebFrameClient*);

+ BLINK_EXPORT static WebLocalFrame* create(WebTreeScopeType, WebFrameClient*, WebFrame* opener = nullptr);

// Used to create a provisional local frame in prepration for replacing a

// remote frame if the load commits. The returned frame is only partially