third_party/WebKit/Source/web/WebLocalFrameImpl.h - Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1685003002: Plumb the correct owner document through DocumentInit::m_owner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change page popup plumbing, remove vestigal bits related to failing security context init Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/SecurityContext.cpp ('K') | « third_party/WebKit/Source/core/page/PagePopupSupplement.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

index a286e03292b0f8d8d12b80a7785b4078012bbd93..eb605d4d7cf0eacd47a84aaee8ac7c43b8d7417e 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

@@ -92,7 +92,6 @@ public:

bool hasHorizontalScrollbar() const override;

bool hasVerticalScrollbar() const override;

WebView* view() const override;

- void setOpener(WebFrame*) override;

WebDocument document() const override;

WebPerformance performance() const override;

bool dispatchBeforeUnloadEvent() override;

@@ -260,7 +259,7 @@ public:

void willBeDetached();

void willDetachParent();

- static WebLocalFrameImpl* create(WebTreeScopeType, WebFrameClient*);

+ static WebLocalFrameImpl* create(WebTreeScopeType, WebFrameClient*, WebFrame* opener);

static WebLocalFrameImpl* createProvisional(WebFrameClient*, WebRemoteFrame*, WebSandboxFlags, const WebFrameOwnerProperties&);

~WebLocalFrameImpl() override;