Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1684963002: Remove Monitoring mode in tracing, and mark unimplemented for another macro (Closed)

Created:
4 years, 10 months ago by fmeawad
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove Monitoring mode in tracing, and mark unimplemented for another macro BUG=559117 LOG=N Committed: https://crrev.com/557915377715f3c081222d1e938ad6d17ad9f362 Cr-Commit-Position: refs/heads/master@{#34042}

Patch Set 1 #

Patch Set 2 : Restore bit values. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/tracing/trace-event.h View 1 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
fmeawad
PTAL.
4 years, 10 months ago (2016-02-10 00:27:54 UTC) #2
oystein (OOO til 10th of July)
On 2016/02/10 00:27:54, fmeawad wrote: > PTAL. I edited the monitoring-removal CL to not change ...
4 years, 10 months ago (2016-02-10 20:20:13 UTC) #3
fmeawad
On 2016/02/10 20:20:13, Oystein wrote: > On 2016/02/10 00:27:54, fmeawad wrote: > > PTAL. > ...
4 years, 10 months ago (2016-02-10 20:25:46 UTC) #4
oystein (OOO til 10th of July)
lgtm
4 years, 10 months ago (2016-02-10 20:27:00 UTC) #6
fmeawad
On 2016/02/10 20:27:00, Oystein wrote: > lgtm Gentle ping.
4 years, 10 months ago (2016-02-16 17:21:17 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-16 17:22:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684963002/20001
4 years, 10 months ago (2016-02-16 17:29:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 17:59:40 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 18:00:19 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/557915377715f3c081222d1e938ad6d17ad9f362
Cr-Commit-Position: refs/heads/master@{#34042}

Powered by Google App Engine
This is Rietveld 408576698