Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1684933002: Fix ash 'gn check' errors; whitelist target. (Closed)

Created:
4 years, 10 months ago by msw
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ash 'gn check' errors; whitelist target. BUG=NONE TEST='gn check out/<DIR> ash' passes; ash target builds/runs as expected. R=sky@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/afbb0c0daf4d298811631c36cbd3c0e93997300f Cr-Commit-Position: refs/heads/master@{#374832}

Patch Set 1 #

Patch Set 2 : Fix chromeos config too. #

Total comments: 2

Patch Set 3 : Resolve many more missing deps, etc. #

Patch Set 4 : Fix additional errors... #

Patch Set 5 : Remove unused windows include. #

Total comments: 2

Patch Set 6 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -7 lines) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download
M ash/BUILD.gn View 1 2 3 4 5 16 chunks +62 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/mus/BUILD.gn View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/chromeos/power/power_event_observer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 38 (15 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 10 months ago (2016-02-09 23:33:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684933002/1
4 years, 10 months ago (2016-02-09 23:36:35 UTC) #3
sky
Nice! LGTM
4 years, 10 months ago (2016-02-09 23:41:14 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/141233)
4 years, 10 months ago (2016-02-09 23:46:12 UTC) #6
msw
I made more changes to fix cros; please take another look.
4 years, 10 months ago (2016-02-09 23:52:58 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684933002/20001
4 years, 10 months ago (2016-02-09 23:54:10 UTC) #9
sky
https://codereview.chromium.org/1684933002/diff/20001/ash/BUILD.gn File ash/BUILD.gn (right): https://codereview.chromium.org/1684933002/diff/20001/ash/BUILD.gn#newcode107 ash/BUILD.gn:107: "//third_party/WebKit/public:blink_headers", Please add a TODO to remove this. ash_with_content ...
4 years, 10 months ago (2016-02-10 00:04:35 UTC) #10
sky
SLGTM
4 years, 10 months ago (2016-02-10 00:04:39 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/141256)
4 years, 10 months ago (2016-02-10 00:06:27 UTC) #13
msw
Hey Scott, this needed many more fixes, please take another look. https://codereview.chromium.org/1684933002/diff/20001/ash/BUILD.gn File ash/BUILD.gn (right): ...
4 years, 10 months ago (2016-02-10 20:30:23 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684933002/40001
4 years, 10 months ago (2016-02-10 20:30:56 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/114345) linux_chromium_compile_dbg_ng on ...
4 years, 10 months ago (2016-02-10 20:42:52 UTC) #18
msw
Sorry, hold off and I'll let you know when the trybot pass
4 years, 10 months ago (2016-02-10 21:20:23 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684933002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684933002/60001
4 years, 10 months ago (2016-02-10 22:00:49 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/101896)
4 years, 10 months ago (2016-02-10 22:21:23 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684933002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684933002/80001
4 years, 10 months ago (2016-02-10 22:39:28 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 23:20:15 UTC) #27
msw
Okay, finally passing. Please take a look; thanks!
4 years, 10 months ago (2016-02-10 23:35:26 UTC) #28
sky
LGTM https://codereview.chromium.org/1684933002/diff/80001/ash/BUILD.gn File ash/BUILD.gn (right): https://codereview.chromium.org/1684933002/diff/80001/ash/BUILD.gn#newcode476 ash/BUILD.gn:476: #if (is_component_build) { Remove this if not necessary.
4 years, 10 months ago (2016-02-11 00:48:44 UTC) #29
msw
+TBR Ben for src/.gn OWNERS https://codereview.chromium.org/1684933002/diff/80001/ash/BUILD.gn File ash/BUILD.gn (right): https://codereview.chromium.org/1684933002/diff/80001/ash/BUILD.gn#newcode476 ash/BUILD.gn:476: #if (is_component_build) { On ...
4 years, 10 months ago (2016-02-11 01:00:20 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684933002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684933002/100001
4 years, 10 months ago (2016-02-11 01:03:57 UTC) #34
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-11 01:54:25 UTC) #36
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:57 UTC) #38
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/afbb0c0daf4d298811631c36cbd3c0e93997300f
Cr-Commit-Position: refs/heads/master@{#374832}

Powered by Google App Engine
This is Rietveld 408576698