Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 168493002: Do not handle mouse wheel events when Ctrl is pressed (Closed)

Created:
6 years, 10 months ago by robwu
Modified:
6 years, 10 months ago
Reviewers:
eae
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Do not handle mouse wheel events when Ctrl is pressed This commit does not change existing behavior. Previously, the renderer would not see Ctrl+scrollwheel at all, because these were intercepted early and not passed to the renderer. However, this has changed in https://codereview.chromium.org/165143003/, to allow web pages to catch and handle the event. To allow the browser to handle Ctrl+scrollwheel (zooming), handleWheelEvent now ignores the event when Ctrl is pressed. Contributed by Rob Wu <rob@robwu.nl>; BUG=111059 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167355

Patch Set 1 #

Total comments: 1

Patch Set 2 : edit comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/core/page/EventHandler.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
robwu
6 years, 10 months ago (2014-02-15 10:55:14 UTC) #1
eae
How does this not change existing behavior? https://codereview.chromium.org/168493002/diff/1/Source/core/page/EventHandler.cpp File Source/core/page/EventHandler.cpp (right): https://codereview.chromium.org/168493002/diff/1/Source/core/page/EventHandler.cpp#newcode2192 Source/core/page/EventHandler.cpp:2192: // Ctrl ...
6 years, 10 months ago (2014-02-18 16:20:25 UTC) #2
robwu
On 2014/02/18 16:20:25, eae wrote: > How does this not change existing behavior? Ctrl + ...
6 years, 10 months ago (2014-02-18 16:40:23 UTC) #3
eae
On 2014/02/18 16:40:23, robwu wrote: > On 2014/02/18 16:20:25, eae wrote: > > How does ...
6 years, 10 months ago (2014-02-18 16:42:00 UTC) #4
robwu
> Ok, that makes sense. Please update the comment and change description and add a ...
6 years, 10 months ago (2014-02-18 16:59:47 UTC) #5
eae
LGTM
6 years, 10 months ago (2014-02-18 17:11:57 UTC) #6
robwu
The CQ bit was checked by rob@robwu.nl
6 years, 10 months ago (2014-02-18 17:12:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob@robwu.nl/168493002/80001
6 years, 10 months ago (2014-02-18 17:12:47 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 19:05:53 UTC) #9
Message was sent while issue was closed.
Change committed as 167355

Powered by Google App Engine
This is Rietveld 408576698