Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 1684923002: Disable more flaky mojo_apptests (Closed)

Created:
4 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 10 months ago
Reviewers:
msw
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable more flaky mojo_apptests Randomly getting "Unrecognized --gtest_list_tests output", which makes no sense to me. Example: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/178678 Only seems to affect network_service_apptests. BUG=569367 TBR=msw@chromium.org TBR=sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/fc51e9e93e12a0f3d6b4f3e1f33c5e252d0dff95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M mojo/tools/data/apptests View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ken Rockot(use gerrit already)
4 years, 10 months ago (2016-02-09 23:29:31 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc51e9e93e12a0f3d6b4f3e1f33c5e252d0dff95 Cr-Commit-Position: refs/heads/master@{#374528}
4 years, 10 months ago (2016-02-09 23:32:10 UTC) #5
Ken Rockot(use gerrit already)
Committed patchset #1 (id:1) manually as fc51e9e93e12a0f3d6b4f3e1f33c5e252d0dff95 (presubmit successful).
4 years, 10 months ago (2016-02-09 23:32:48 UTC) #7
Ken Rockot(use gerrit already)
4 years, 10 months ago (2016-02-09 23:37:27 UTC) #8
Message was sent while issue was closed.
As jbroman suggested, this is due to the fact that network_service_apptests
no longer have any dependent targets (bye bye mandoline) and therefore
don't ever build. We should make them build again :)

On Tue, Feb 9, 2016 at 3:32 PM, rockot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Committed patchset #1 (id:1) manually as
> fc51e9e93e12a0f3d6b4f3e1f33c5e252d0dff95 (presubmit successful).
> https://codereview.chromium.org/1684923002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698