Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1684913002: Resolve correct noSuchMethod (fixes #25671, #25737). (Closed)

Created:
4 years, 10 months ago by regis
Modified:
4 years, 10 months ago
Reviewers:
srdjan, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +17 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
4 years, 10 months ago (2016-02-09 23:27:54 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1684913002/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/1684913002/diff/1/runtime/vm/flow_graph_builder.cc#newcode4449 runtime/vm/flow_graph_builder.cc:4449: Array::Handle(ArgumentsDescriptor::New(kNumArguments))); Handle(Z,
4 years, 10 months ago (2016-02-09 23:48:09 UTC) #3
hausner
LGTM.
4 years, 10 months ago (2016-02-09 23:48:39 UTC) #4
regis
Thanks! https://codereview.chromium.org/1684913002/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/1684913002/diff/1/runtime/vm/flow_graph_builder.cc#newcode4449 runtime/vm/flow_graph_builder.cc:4449: Array::Handle(ArgumentsDescriptor::New(kNumArguments))); On 2016/02/09 23:48:09, srdjan wrote: > Handle(Z, ...
4 years, 10 months ago (2016-02-10 00:06:46 UTC) #5
regis
4 years, 10 months ago (2016-02-10 00:08:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fb2dab5f43534ae0e43d0b493ee3eee54113b5ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698