Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc

Issue 1684823004: Refactors keyboard related code so mash can use a keyboard (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge to trunk Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h ('k') | ash/test/test_shell_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
diff --git a/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc b/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
index 8bdbb59bfdf7328d670feb4db3bc37e14f700b82..7d29777fcc255efdde70434a3b93969c755cb534 100644
--- a/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
+++ b/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
@@ -4,6 +4,7 @@
#include "ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h"
+#include "ash/keyboard/keyboard_ui.h"
#include "ash/shelf/shelf.h"
#include "ash/shelf/shelf_constants.h"
#include "ash/shell.h"
@@ -17,7 +18,6 @@
#include "ui/base/resource/resource_bundle.h"
#include "ui/events/event.h"
#include "ui/gfx/image/image_skia.h"
-#include "ui/keyboard/keyboard_controller.h"
#include "ui/views/controls/button/image_button.h"
namespace ash {
@@ -35,18 +35,14 @@ VirtualKeyboardTray::VirtualKeyboardTray(StatusAreaWidget* status_area_widget)
tray_container()->AddChildView(button_);
SetContentsBackground();
// The Shell may not exist in some unit tests.
- if (Shell::HasInstance()) {
- Shell::GetInstance()->system_tray_notifier()->
- AddAccessibilityObserver(this);
- }
+ if (Shell::HasInstance())
+ Shell::GetInstance()->keyboard_ui()->AddObserver(this);
}
VirtualKeyboardTray::~VirtualKeyboardTray() {
// The Shell may not exist in some unit tests.
- if (Shell::HasInstance()) {
- Shell::GetInstance()->system_tray_notifier()->
- RemoveAccessibilityObserver(this);
- }
+ if (Shell::HasInstance())
+ Shell::GetInstance()->keyboard_ui()->RemoveObserver(this);
}
void VirtualKeyboardTray::SetShelfAlignment(ShelfAlignment alignment) {
@@ -92,7 +88,7 @@ bool VirtualKeyboardTray::ClickedOutsideBubble() {
}
bool VirtualKeyboardTray::PerformAction(const ui::Event& event) {
- keyboard::KeyboardController::GetInstance()->ShowKeyboard(true);
+ Shell::GetInstance()->keyboard_ui()->Show();
return true;
}
@@ -102,10 +98,8 @@ void VirtualKeyboardTray::ButtonPressed(views::Button* sender,
PerformAction(event);
}
-void VirtualKeyboardTray::OnAccessibilityModeChanged(
- ui::AccessibilityNotificationVisibility notify) {
- SetVisible(Shell::GetInstance()->accessibility_delegate()->
- IsVirtualKeyboardEnabled());
+void VirtualKeyboardTray::OnKeyboardEnabledStateChanged(bool new_value) {
+ SetVisible(Shell::GetInstance()->keyboard_ui()->IsEnabled());
}
} // namespace ash
« no previous file with comments | « ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h ('k') | ash/test/test_shell_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698