Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 16848020: Always reset allowed OSR nesting level when reverting interrupt code patches. (Closed)

Created:
7 years, 6 months ago by Jakob Kummerow
Modified:
7 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Always reset allowed OSR nesting level when reverting interrupt code patches. Also, --trap-on-deopt should only affect optimized functions, not hydrogen stubs. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 6 months ago (2013-06-19 09:26:16 UTC) #1
Yang
On 2013/06/19 09:26:16, Jakob wrote: > PTAL. LGTM.
7 years, 6 months ago (2013-06-19 09:36:22 UTC) #2
Jakob Kummerow
7 years, 6 months ago (2013-06-19 09:38:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15204 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698