Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2437)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 16848019: More debug info on the browser controller. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
===================================================================
--- tools/testing/dart/browser_controller.dart (revision 23998)
+++ tools/testing/dart/browser_controller.dart (working copy)
@@ -759,6 +759,7 @@
return HttpServer.bind(local_ip, 0).then((createdServer) {
httpServer = createdServer;
void handler(HttpRequest request) {
+ DebugLogger.info("Handling request to: ${request.uri.path}");
if (request.uri.path.startsWith(reportPath)) {
var browserId = request.uri.path.substring(reportPath.length + 1);
var testId = int.parse(request.queryParameters["id"].split("=")[1]);
@@ -776,11 +777,14 @@
var browserId = request.uri.path.substring(nextTestPath.length + 1);
textResponse = getNextTest(browserId);
} else {
- // We silently ignore other requests.
+ DebugLogger.info("Handling non standard request to: "
+ "${request.uri.path}");
}
request.response.write(textResponse);
request.listen((_) {}, onDone: request.response.close);
- request.response.done.catchError((error) {
+ request.response.done.then((_) {
+ DebugLogger.info("Done handling request to: ${request.uri.path}");
+ }).catchError((error) {
if (!underTermination) {
print("URI ${request.uri}");
print("Textresponse $textResponse");
@@ -830,6 +834,7 @@
String back = buffer.toString();
request.response.close();
testDoneCallBack(browserId, back, testId);
+ DebugLogger.info("Done handling request to: ${request.uri.path}");
}, onError: (error) { print(error); });
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698