Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16848005: Remove support for multipart/x-mixed-replace (Closed)

Created:
7 years, 6 months ago by abarth-chromium
Modified:
7 years, 6 months ago
CC:
blink-reviews, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org, eseidel, japhet-do-not-use
Visibility:
Public.

Description

Remove support for multipart/x-mixed-replace This feature adds a lot of complexity to the loader and is used by less than 0.00001% of page loads. R=darin BUG=249132 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152363

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -297 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/http/tests/multipart/invalid-image-data-standalone.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/http/tests/multipart/load-last-non-html-frame.php View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/http/tests/multipart/load-last-non-html-frame-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/http/tests/multipart/multipart-html.php View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/http/tests/multipart/multipart-html-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/multipart/multipart-replace-non-html-content.php View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/http/tests/multipart/multipart-wait-before-boundary.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/http/tests/multipart/policy-ignore-crash.php View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/http/tests/multipart/policy-ignore-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/multipart/resources/multipart-nodashes.php View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/multipart/resources/multipart-wait-before-boundary.php View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/http/tests/multipart/win-boundary-crash.html-disabled View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/http/tests/multipart/win-boundary-crash-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 1 chunk +1 line, -0 lines 2 comments Download
M Source/core/loader/DocumentLoader.h View 4 chunks +0 lines, -6 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 7 chunks +3 lines, -48 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/loader/ResourceLoader.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
7 years, 6 months ago (2013-06-12 22:48:44 UTC) #1
darin (slow to review)
https://codereview.chromium.org/16848005/diff/1/Source/WebKit/chromium/src/WebFrameImpl.cpp File Source/WebKit/chromium/src/WebFrameImpl.cpp (right): https://codereview.chromium.org/16848005/diff/1/Source/WebKit/chromium/src/WebFrameImpl.cpp#newcode991 Source/WebKit/chromium/src/WebFrameImpl.cpp:991: // FIXME: Can we use lock history instead? nit: ...
7 years, 6 months ago (2013-06-12 22:55:06 UTC) #2
abarth-chromium
https://codereview.chromium.org/16848005/diff/1/Source/WebKit/chromium/src/WebFrameImpl.cpp File Source/WebKit/chromium/src/WebFrameImpl.cpp (right): https://codereview.chromium.org/16848005/diff/1/Source/WebKit/chromium/src/WebFrameImpl.cpp#newcode991 Source/WebKit/chromium/src/WebFrameImpl.cpp:991: // FIXME: Can we use lock history instead? On ...
7 years, 6 months ago (2013-06-12 23:20:24 UTC) #3
darin (slow to review)
Ah, I see. LGTM
7 years, 6 months ago (2013-06-12 23:21:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/16848005/1
7 years, 6 months ago (2013-06-12 23:22:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/16848005/1
7 years, 6 months ago (2013-06-13 17:11:05 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 17:50:04 UTC) #7
Message was sent while issue was closed. 
Change committed as 152363

Powered by Google App Engine
This is Rietveld 408576698