Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: pkg/stack_trace/lib/src/frame.dart

Issue 16848002: Add toUri and fromUri functions to pathos. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Preserve trailing separators. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/pathos/test/pathos_windows_test.dart ('k') | pkg/stack_trace/lib/src/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/stack_trace/lib/src/frame.dart
diff --git a/pkg/stack_trace/lib/src/frame.dart b/pkg/stack_trace/lib/src/frame.dart
index 8f1931bc216403a4a3e57f92bde71e6c20220aef..8d3f042a20533b9ba0dcc9d0b71c18164f761e84 100644
--- a/pkg/stack_trace/lib/src/frame.dart
+++ b/pkg/stack_trace/lib/src/frame.dart
@@ -8,7 +8,6 @@ library frame;
import 'package:pathos/path.dart' as path;
import 'trace.dart';
-import 'utils.dart';
final _nativeFrameRegExp = new RegExp(
r'^#\d+\s+([^\s].*) \((.+):(\d+):(\d+)\)$');
@@ -46,9 +45,8 @@ class Frame {
/// This will usually be the string form of [uri], but a relative path will be
/// used if possible.
String get library {
- // TODO(nweiz): handle relative URIs here as well once pathos supports that.
if (uri.scheme != 'file') return uri.toString();
- return path.relative(fileUriToPath(uri));
+ return path.relative(path.fromUri(uri));
}
/// Returns the name of the package this stack frame comes from, or `null` if
« no previous file with comments | « pkg/pathos/test/pathos_windows_test.dart ('k') | pkg/stack_trace/lib/src/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698