Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: media/cast/sender/frame_sender.cc

Issue 1684793003: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/cast/receiver/frame_receiver.cc ('k') | ui/gfx/range/range.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/sender/frame_sender.h" 5 #include "media/cast/sender/frame_sender.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/numerics/safe_conversions.h"
13 #include "base/trace_event/trace_event.h" 14 #include "base/trace_event/trace_event.h"
14 #include "media/cast/cast_defines.h" 15 #include "media/cast/cast_defines.h"
15 #include "media/cast/constants.h" 16 #include "media/cast/constants.h"
16 #include "media/cast/sender/sender_encoded_frame.h" 17 #include "media/cast/sender/sender_encoded_frame.h"
17 18
18 namespace media { 19 namespace media {
19 namespace cast { 20 namespace cast {
20 namespace { 21 namespace {
21 22
22 const int kMinSchedulingDelayMs = 1; 23 const int kMinSchedulingDelayMs = 1;
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 233
233 VLOG_IF(1, !is_audio_ && encoded_frame->dependency == EncodedFrame::KEY) 234 VLOG_IF(1, !is_audio_ && encoded_frame->dependency == EncodedFrame::KEY)
234 << SENDER_SSRC << "Sending encoded key frame, id=" << frame_id; 235 << SENDER_SSRC << "Sending encoded key frame, id=" << frame_id;
235 236
236 scoped_ptr<FrameEvent> encode_event(new FrameEvent()); 237 scoped_ptr<FrameEvent> encode_event(new FrameEvent());
237 encode_event->timestamp = encoded_frame->encode_completion_time; 238 encode_event->timestamp = encoded_frame->encode_completion_time;
238 encode_event->type = FRAME_ENCODED; 239 encode_event->type = FRAME_ENCODED;
239 encode_event->media_type = is_audio_ ? AUDIO_EVENT : VIDEO_EVENT; 240 encode_event->media_type = is_audio_ ? AUDIO_EVENT : VIDEO_EVENT;
240 encode_event->rtp_timestamp = encoded_frame->rtp_timestamp; 241 encode_event->rtp_timestamp = encoded_frame->rtp_timestamp;
241 encode_event->frame_id = frame_id; 242 encode_event->frame_id = frame_id;
242 encode_event->size = encoded_frame->data.size(); 243 encode_event->size = base::checked_cast<uint32_t>(encoded_frame->data.size());
243 encode_event->key_frame = encoded_frame->dependency == EncodedFrame::KEY; 244 encode_event->key_frame = encoded_frame->dependency == EncodedFrame::KEY;
244 encode_event->target_bitrate = requested_bitrate_before_encode; 245 encode_event->target_bitrate = requested_bitrate_before_encode;
245 encode_event->encoder_cpu_utilization = encoded_frame->deadline_utilization; 246 encode_event->encoder_cpu_utilization = encoded_frame->deadline_utilization;
246 encode_event->idealized_bitrate_utilization = 247 encode_event->idealized_bitrate_utilization =
247 encoded_frame->lossy_utilization; 248 encoded_frame->lossy_utilization;
248 cast_environment_->logger()->DispatchFrameEvent(std::move(encode_event)); 249 cast_environment_->logger()->DispatchFrameEvent(std::move(encode_event));
249 250
250 RecordLatestFrameTimestamps(frame_id, 251 RecordLatestFrameTimestamps(frame_id,
251 encoded_frame->reference_time, 252 encoded_frame->reference_time,
252 encoded_frame->rtp_timestamp); 253 encoded_frame->rtp_timestamp);
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 VLOG(1) << SENDER_SSRC << "Dropping: In-flight duration would be too high."; 421 VLOG(1) << SENDER_SSRC << "Dropping: In-flight duration would be too high.";
421 return true; 422 return true;
422 } 423 }
423 424
424 // Next frame is accepted. 425 // Next frame is accepted.
425 return false; 426 return false;
426 } 427 }
427 428
428 } // namespace cast 429 } // namespace cast
429 } // namespace media 430 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/receiver/frame_receiver.cc ('k') | ui/gfx/range/range.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698