Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Side by Side Diff: media/cast/logging/logging_defines.h

Issue 1684793003: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/common/stack_frame.h ('k') | media/cast/net/pacing/paced_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_CAST_LOGGING_LOGGING_DEFINES_H_ 5 #ifndef MEDIA_CAST_LOGGING_LOGGING_DEFINES_H_
6 #define MEDIA_CAST_LOGGING_LOGGING_DEFINES_H_ 6 #define MEDIA_CAST_LOGGING_LOGGING_DEFINES_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 ~FrameEvent(); 57 ~FrameEvent();
58 58
59 RtpTimeTicks rtp_timestamp; 59 RtpTimeTicks rtp_timestamp;
60 uint32_t frame_id; 60 uint32_t frame_id;
61 61
62 // Resolution of the frame. Only set for video FRAME_CAPTURE_END events. 62 // Resolution of the frame. Only set for video FRAME_CAPTURE_END events.
63 int width; 63 int width;
64 int height; 64 int height;
65 65
66 // Size of encoded frame in bytes. Only set for FRAME_ENCODED event. 66 // Size of encoded frame in bytes. Only set for FRAME_ENCODED event.
67 // Note: we use uint32_t instead of size_t for byte count because this struct
68 // is sent over IPC which could span 32 & 64 bit processes.
67 uint32_t size; 69 uint32_t size;
68 70
69 // Time of event logged. 71 // Time of event logged.
70 base::TimeTicks timestamp; 72 base::TimeTicks timestamp;
71 73
72 CastLoggingEvent type; 74 CastLoggingEvent type;
73 75
74 EventMediaType media_type; 76 EventMediaType media_type;
75 77
76 // Only set for FRAME_PLAYOUT events. 78 // Only set for FRAME_PLAYOUT events.
(...skipping 28 matching lines...) Expand all
105 // Time of event logged. 107 // Time of event logged.
106 base::TimeTicks timestamp; 108 base::TimeTicks timestamp;
107 CastLoggingEvent type; 109 CastLoggingEvent type;
108 EventMediaType media_type; 110 EventMediaType media_type;
109 }; 111 };
110 112
111 } // namespace cast 113 } // namespace cast
112 } // namespace media 114 } // namespace media
113 115
114 #endif // MEDIA_CAST_LOGGING_LOGGING_DEFINES_H_ 116 #endif // MEDIA_CAST_LOGGING_LOGGING_DEFINES_H_
OLDNEW
« no previous file with comments | « extensions/common/stack_frame.h ('k') | media/cast/net/pacing/paced_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698